Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiohttp mock breaks aiohttp request tracing #152

Open
sarayourfriend opened this issue Oct 24, 2024 · 0 comments
Open

aiohttp mock breaks aiohttp request tracing #152

sarayourfriend opened this issue Oct 24, 2024 · 0 comments
Labels

Comments

@sarayourfriend
Copy link
Collaborator

Pook's aiohttp mock breaks aiohttp's request tracing: https://docs.aiohttp.org/en/stable/tracing_reference.html#aiohttp-client-tracing-reference

Tracing happens within the client's _request method, which Pook overwrites with a mock.

Pook should mock something lower level in aiohttp. I think that would need to be ClientRequest.write_bytes, based on a cursory glance at the aiohttp implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant