Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Go 1.19 #25

Closed
paralin opened this issue Aug 10, 2022 · 5 comments · Fixed by #28
Closed

Update to Go 1.19 #25

paralin opened this issue Aug 10, 2022 · 5 comments · Fixed by #28

Comments

@paralin
Copy link

paralin commented Aug 10, 2022

What's needed to rebase the go1.16 branch on go1.19?
@paralin
Copy link
Author

paralin commented Aug 10, 2022

@JohnStarich I've done it here, not too bad:

https://github.com/paralin/go/tree/hackpad/release-branch.go1.19

@paralin
Copy link
Author

paralin commented Aug 10, 2022

hack-pad/hackpadfs#20

paralin added a commit to paralin/hackpad that referenced this issue Aug 10, 2022
@paralin
[RFC] refactor: update to go 1.19
7840566 
Marked RFC until these are merged:

 - https://github.com/paralin/go/tree/hackpad/release-branch.go1.19
 - hack-pad/hackpadfs#20

Fixes hack-pad#25

Signed-off-by: Christian Stewart <[email protected]>
@paralin paralin mentioned this issue Aug 10, 2022
Closed
paralin added a commit to paralin/hackpad that referenced this issue Aug 10, 2022
@paralin
[RFC] refactor: update to go 1.19
2e53f21 
Marked RFC until these are merged:

 - https://github.com/paralin/go/tree/hackpad/release-branch.go1.19
 - hack-pad/hackpadfs#20

Fixes hack-pad#25

Signed-off-by: Christian Stewart <[email protected]>
paralin added a commit to paralin/hackpad that referenced this issue Aug 10, 2022
@paralin
[RFC] refactor: update to go 1.19
efb25a8 
Marked RFC until these are merged:

 - https://github.com/paralin/go/tree/hackpad/release-branch.go1.19
 - hack-pad/hackpadfs#20

Fixes hack-pad#25

Signed-off-by: Christian Stewart <[email protected]>
@JohnStarich
Copy link
Collaborator

Awesome, thanks @paralin. Sorry for the delays on my end, it's been tough finding time to debug the issues in #18.

@paralin
Copy link
Author

paralin commented Oct 5, 2022

No problem!

@JohnStarich JohnStarich mentioned this issue Apr 12, 2023
Merged
@JohnStarich
Copy link
Collaborator

Merged in upgrade to 1.20! 🎉

Thanks again for the library fixes ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to Go 1.20 hack-pad/hackpad
[RFC] refactor: update to go 1.19 paralin/hackpad
2 participants
@paralin @JohnStarich