Add greeting for new players through /tutorial #88

jasonappah · 2020-04-30T20:27:28Z

If you run /tutorial you'll get this:

New players will also get that when they join.

Closes #86.

jasonappah · 2020-04-30T20:53:35Z

Btw the code is kinda jank but it works, so if anyone has suggestions of what to edit, I can definitely try to fix it.

ifvictr · 2020-04-30T22:52:16Z

src/main/java/com/hackclub/hccore/listeners/PlayerListener.java

@@ -68,7 +68,11 @@ public void onPlayerJoin(final PlayerJoinEvent event) {
        event.getPlayer().resetTitle();
        event.setJoinMessage(ChatColor.YELLOW
                + ChatColor.stripColor(event.getPlayer().getDisplayName()) + " joined the game");
-    }
+


Can you fix the indentation here?

src/main/java/com/hackclub/hccore/listeners/PlayerListener.java

ifvictr · 2020-04-30T22:54:21Z

src/main/java/com/hackclub/hccore/commands/TutorialCommand.java

+import org.bukkit.entity.Player;
+
+public class TutorialCommand implements CommandExecutor {
+    private static final String[] message = {ChatColor.RED + "Greetings! Welcome to the Hack Club vanilla Minecraft server!", "You can use /nick to set your nick name and /color to set your chat and name colors", ChatColor.RED + "Rules:\n", "Be nice.",  "No griefing.", "Don't build within 1000 blocks of spawn.", "If you want to contribute to plugin development head on over to the GitHub: " + ChatColor.RED + "https://github.com/hackclub/HCCore/. ", "Type /tutorial to see this at any time."};


Can you use the Java code linter? It'll automatically split it into multiple lines.

ifvictr · 2020-04-30T22:54:30Z

src/main/java/com/hackclub/hccore/commands/TutorialCommand.java

+        Player player = (Player) sender;
+        for (String i : TutorialCommand.message) {
+            sender.sendMessage(ChatColor.YELLOW + "" + ChatColor.BOLD + i);
+            }


Indentation

src/main/java/com/hackclub/hccore/commands/TutorialCommand.java

src/main/resources/plugin.yml

ifvictr · 2020-04-30T22:59:07Z

src/main/java/com/hackclub/hccore/listeners/PlayerListener.java

-    }
+
+        if (event.getPlayer().hasPlayedBefore() == false) {
+            event.getPlayer().performCommand("tutorial");


You should make a function called startTutorialFlow that takes a player as the parameter. This feels a little hacky lol.

src/main/java/com/hackclub/hccore/commands/TutorialCommand.java

nice6599 · 2020-05-02T22:15:29Z

src/main/java/com/hackclub/hccore/commands/TutorialCommand.java

+import org.bukkit.entity.Player;
+
+public class TutorialCommand implements CommandExecutor {
+    private static final String[] message = {ChatColor.RED + "Greetings! Welcome to the Hack Club vanilla Minecraft server!", "You can use /nick to set your nick name and /color to set your chat and name colors", ChatColor.RED + "Rules:\n", "Be nice.",  "No griefing.", "Don't build within 1000 blocks of spawn.", "If you want to contribute to plugin development head on over to the GitHub: " + ChatColor.RED + "https://github.com/hackclub/HCCore/. ", "Type /tutorial to see this at any time."};


I suggest that you include the "greeting" part in a new player event so "greeting" does not message when you run the command again.

nice6599 · 2020-05-02T22:15:36Z

src/main/resources/plugin.yml

@@ -32,3 +32,7 @@ commands:
  tableflip:
    description: Appends a tableflip to your message
    usage: /tableflip [message]
+  tutorial:
+    description: Greets new users to the server


fix description. the command itself does not greet new users.

I suggest that you include the "greeting" part in a new player event so "greeting" does not message when you run the command again.

zanedb · 2020-11-09T22:54:18Z

Honestly, I'm not sure text is the best way to introduce the rules. I think a lot of players will ignore or skim over it, especially when joining. I've seen a few servers do a floating item frame walkway that introduces the rules at their spawn, which I quite like:

If we're building a new spawn area (which @eankeen & I have talked about), perhaps we could do something similar to the above in that area. Then, maybe this command could become /info (so you don't have to go to spawn to see the rules). What do y'all think?

hyperupcall · 2020-11-10T03:02:55Z

yeah not just having raw text would look much nicer

jasonappah · 2020-11-10T04:24:00Z

Omg I totally forgot about this PR! I do like the item frame idea a lot more though

…

On Mon, Nov 9, 2020 at 9:03 PM Edwin Kofler ***@***.***> wrote: yeah not just having raw text would look much nicer — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#88 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHJQZCO26DL33WEABQD22STSPCUOXANCNFSM4MWSU2IQ> .

src/main/java/com/hackclub/hccore/commands/TutorialCommand.java

Co-authored-by: Alex Park <[email protected]>

jasonappah · 2021-07-14T20:19:57Z

I think this PR is GTG, just need to run linting rq

alx-alexpark

Looks good, just don't forget to mention the modded server, its important so put it in bold, thanks :) after that i'l merge

jasonappah · 2021-07-14T21:53:16Z

Correct me if I'm wrong but I already have it bolded

Monoverde888 · 2024-09-18T01:49:54Z

why was this closed?

polypixeldev · 2024-09-18T03:00:28Z

why was this closed?

old pr that would've needed a lot of time spent to make work with new code - but if you @Monoverde888 would like to try to get this pr in a working state feel free!

jasonappah added 5 commits April 30, 2020 11:11

Created TutorialCommand.java

47cd73c

Added /tutorial to plugins.yml

282f4b2

Added tutorial command to PlayerListener.java

921b9e1

Finished /tutorial command

00a8ab0

Run /tutorial when new players join

1f17838

ifvictr requested changes Apr 30, 2020

View reviewed changes

jasonappah added 2 commits April 30, 2020 19:43

remove extra space in plugin.yml

3df48fb

capitalized name of static array message

b578fee

ifvictr marked this pull request as draft May 1, 2020 19:43

ifvictr marked this pull request as ready for review May 1, 2020 19:43

Merge branch 'master' into master

c14b55d

nice6599 added the enhancement New feature or request label May 2, 2020

nice6599 self-requested a review May 2, 2020 22:04

nice6599 reviewed May 2, 2020

View reviewed changes

jasonappah added 5 commits May 2, 2020 21:11

Get rid of unused variable player

be30415

Moved for loop into if else statement

baa942f

Simplified L26

9693fb7

Removed extra spaces

4003993

Merge branch 'master' of https://github.com/jasonappah/HCCore

1ca7f94

ifvictr changed the title ~~Add Greeting for New Players~~ Add greeting for new players through /tutorial May 3, 2020

jasonappah marked this pull request as draft May 4, 2020 02:58

Merge branch 'master' into master

c387f45

nice6599 self-requested a review November 10, 2020 15:05

alx-alexpark requested changes Jul 6, 2021

View reviewed changes

src/main/java/com/hackclub/hccore/commands/TutorialCommand.java Outdated Show resolved Hide resolved

Fix autocomplete for second parameter of /stats (hackclub#95)

0b84b59

jasonappah and others added 22 commits July 5, 2021 23:25

Added /tutorial to plugins.yml

a40c395

Added tutorial command to PlayerListener.java

d0c0587

Finished /tutorial command

91f5ead

Run /tutorial when new players join

50505cd

capitalized name of static array message

4d03fb3

Get rid of unused variable player

3dfda39

Moved for loop into if else statement

8aeb7de

Simplified L26

b334808

Removed extra spaces

cca345b

Added /upvote and /downvote (hackclub#103)

b4de51e

Allow spaces in loc command

1dfd3e1

Delimit location names with underscores

b463df5

Replace argString with locationName

2379982

Remove getArgAsString, it's not necessary

55b65b4

Added Discord integration

b5be2a1

Added /tutorial to plugins.yml

c642e80

Added tutorial command to PlayerListener.java

5c20e33

chore: undo accidental version change

5dff6a3

chore: merge

a427cf3

Update src/main/java/com/hackclub/hccore/commands/TutorialCommand.java

db289c2

Co-authored-by: Alex Park <[email protected]>

chore: remove broken import

2889df8

feat+refactor: separate greeting/rules message

6bcde1e

jasonappah marked this pull request as ready for review July 14, 2021 20:19

style: lint and format

6a55070

alx-alexpark reviewed Jul 14, 2021

View reviewed changes

polypixeldev closed this Sep 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add greeting for new players through /tutorial #88

Add greeting for new players through /tutorial #88

jasonappah commented Apr 30, 2020

jasonappah commented Apr 30, 2020

ifvictr Apr 30, 2020

ifvictr Apr 30, 2020

ifvictr Apr 30, 2020

ifvictr Apr 30, 2020

nice6599 May 2, 2020

nice6599 May 2, 2020

zanedb commented Nov 9, 2020

hyperupcall commented Nov 10, 2020

jasonappah commented Nov 10, 2020 via email

jasonappah commented Jul 14, 2021

alx-alexpark left a comment

jasonappah commented Jul 14, 2021

Monoverde888 commented Sep 18, 2024

polypixeldev commented Sep 18, 2024

Add greeting for new players through /tutorial #88

Add greeting for new players through /tutorial #88

Conversation

jasonappah commented Apr 30, 2020

jasonappah commented Apr 30, 2020

ifvictr Apr 30, 2020

Choose a reason for hiding this comment

ifvictr Apr 30, 2020

Choose a reason for hiding this comment

ifvictr Apr 30, 2020

Choose a reason for hiding this comment

ifvictr Apr 30, 2020

Choose a reason for hiding this comment

nice6599 May 2, 2020

Choose a reason for hiding this comment

nice6599 May 2, 2020

Choose a reason for hiding this comment

zanedb commented Nov 9, 2020

hyperupcall commented Nov 10, 2020

jasonappah commented Nov 10, 2020 via email

jasonappah commented Jul 14, 2021

alx-alexpark left a comment

Choose a reason for hiding this comment

jasonappah commented Jul 14, 2021

Monoverde888 commented Sep 18, 2024

polypixeldev commented Sep 18, 2024