Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal templates could link back to the PR #55

Open
adamgundry opened this issue Aug 3, 2023 · 3 comments
Open

Proposal templates could link back to the PR #55

adamgundry opened this issue Aug 3, 2023 · 3 comments
Assignees

Comments

@adamgundry
Copy link
Contributor

For ghc-proposals, the proposal template includes a link back to the PR, which makes it easy to find the canonical place for discussion. Could we do the same here?

For example I was reading https://github.com/simonpj/hf-tech-proposals/blob/ghc-module-naming-2023/proposals/0000-ghc-module-naming.rst and it's not trivial to navigate back to #53.

@tek
Copy link
Contributor

tek commented Aug 3, 2023

I had the same experience today.

@adamgundry
Copy link
Contributor Author

Ah, it appears that accepted proposals are mostly numbered after the PR number (in proposals/accepted), except this convention doesn't appear to be documented in PROPOSALS.md and doesn't appear to be enforced consistently (e.g. some proposals are in proposals/ and are numbered 0000). There is also a new rfc directory for RFCs being introduced in #60 (comment).

Perhaps someone could overhaul PROPOSALS.md to mention how accepted proposals are supposed to be organised, and correct those that don't fit the scheme?

@jmct jmct self-assigned this Apr 24, 2024
@jmct
Copy link
Contributor

jmct commented Apr 24, 2024

I will do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants