Autosave after-delay doesn't work

[DoctorRyner]

Summary

I'm testing auto-save update, new focus-lost setting works but after-delay doesn't

[editor.auto-save]
focus-lost = true
after-delay.enable = true
after-delay.timeout = 1

Reproduction Steps

1. Build from a64dbf8

2. Set auto-save settings as:

[editor.auto-save]
focus-lost = true
after-delay.enable = true
after-delay.timeout = 1

3. try editing a file

Helix log

No response

Platform

macOS

Terminal Emulator

iTerm 2

Installation Method

source

Helix Version

a64dbf8

[the-mikedavis]

I see that config working locally. Note that timeout is in milliseconds so that config is saving instantly after any edit.

[DoctorRyner]

@the-mikedavis

Hm, maybe it's a macOS unique bug? I recorded it not working

CleanShot.2024-06-11.at.17.10.19.mp4

[David-Else]

I just tested it on Linux/Kitty and it is working great, I am sure the team will fix it quickly if it is a macOS unique bug.

[kirawi]

I tested on Mac with the current master and it works, although the modification bool isn't reset. Though the latter may be a bug for all OSes for very small timeouts.

[pascalkuthe]

With the modification bool you just mean whether helix shows the file as modified, right?

I suspect that such a ultra-low timeout may be triggering a very niche race conditions. I thought the existing save handling should handle that but that may not actually be the case. If that is the case then this is an existing bug and can occur with normal saves (just that you rarely save fast enough to observe it). It shouldn't be very likely with a normal timeout.

[DoctorRyner]

I tried different values, it doesn’t work for some reason..

[DoctorRyner]

@pascalkuthe I actually found out that it works with TypeScript (even such low values as 1) but doesn't work for Go for some reason

[kirawi]

Can you try disabling auto-format? Maybe that's the issue. Or perhaps the LSP is getting overloaded with requests.

[justforcomment]

Can you try disabling auto-format? Maybe that's the issue. Or perhaps the LSP is getting overloaded with requests.

I tried disabling LSP. Autosave now works (for Rust files). But this is not a solution of problem. Besides, there is also some strangeness associated with this, which I described here: #10991

[justforcomment]

Hello!
I have the same problem.
auto-save (regardless of the timeout duration) does not work when editing Rust (may other) files, but does work for TypeScript (may other) or files without an extension.

OS: Linux/Devuan/Xfce4.
Terminal: Kitty, also in xfce4-terminal.

helix_auto_save_issue.mp4

[dessalines]

If you set auto-format = false in your rust languages block, the auto-save works again.