Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an e2e test to verify the --comm option works fine #212

Open
hengyoush opened this issue Dec 23, 2024 · 3 comments · May be fixed by #222
Open

Add an e2e test to verify the --comm option works fine #212

hengyoush opened this issue Dec 23, 2024 · 3 comments · May be fixed by #222
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed test

Comments

@hengyoush
Copy link
Owner

hengyoush commented Dec 23, 2024

Is your feature request related to a problem? Please describe.
Add an e2e test to verify the --comm (filter by process name) option works fine

Describe the solution you'd like

  1. Add a bash script file in testdata/ which contains the main test logic. (like this one: test_docker_filter_by_pid.sh), including two cases:

    1. target process start , then kyanos start , expected kyanos can watch the target process's network.
    2. kyanos start, then target process start, expected kyanos can watch the target process's network.
  2. Add a step in workflow : .github/workflows/test.yml which executes the test script file in 1.

@hengyoush hengyoush added help wanted Extra attention is needed good first issue Good for newcomers test labels Dec 23, 2024
@hengyoush hengyoush added this to v1.5.0 Dec 23, 2024
@hengyoush hengyoush moved this to Todo in v1.5.0 Dec 23, 2024
@hengyoush hengyoush self-assigned this Dec 25, 2024
@spencercjh
Copy link
Contributor

spencercjh commented Dec 27, 2024

Can a simple Python HTTP server be started directly (not in a Docker container) in this e2e test?

image
image

sudo ./kyanos watch -d http --comm python3

image

I need to simulate my local operation in the test.

AM I RIGHT?

@spencercjh
Copy link
Contributor

You haven't started this work yet, have you?

@hengyoush
Copy link
Owner Author

hengyoush commented Dec 27, 2024

You haven't started this work yet, have you?

No, I haven't.

Can a simple Python HTTP server be started directly (not in a Docker container) in this e2e test?

ok.

@spencercjh Thank you very much, assigned this issue to you.

@hengyoush hengyoush assigned spencercjh and unassigned hengyoush Dec 27, 2024
@spencercjh spencercjh linked a pull request Dec 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed test
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

2 participants