improved/fixed CAP_INTERNAL_CONSTRUCTIVE_CATEGORIES_RECORD.IsAbelianCategory #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamalsaleh
reviewed
Oct 6, 2023
| @@ -94,8 +94,7 @@ CAP_INTERNAL_CONSTRUCTIVE_CATEGORIES_RECORD.IsPreAbelianCategory := Concatenatio | |||
| CAP_INTERNAL_CONSTRUCTIVE_CATEGORIES_RECORD.IsAbelianCategory := Concatenation( | |||
| CAP_INTERNAL_CONSTRUCTIVE_CATEGORIES_RECORD.IsPreAbelianCategory, | |||
| [ | |||
| "LiftAlongMonomorphism", | |||
| "ColiftAlongEpimorphism", | |||
| "InverseOfMorphismFromCoimageToImage", | |||
| ] | |||
There was a problem hiding this comment.
I am not sure why the operations LiftAlongMonomorphism and ColiftAlongEpimorphism might be removed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1487 +/- ##
==========================================
- Coverage 81.52% 81.20% -0.32%
==========================================
Files 536 559 +23
Lines 77376 79563 +2187
==========================================
+ Hits 63079 64610 +1531
- Misses 14297 14953 +656
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mohamed-barakat
force-pushed
the
IsAbelianCategory
branch
from
8cef042 to
e982e45
Compare
mohamed-barakat
force-pushed
the
IsAbelianCategory
branch
from
e982e45 to
9490e3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1473