Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-native] Some iosUtils code paths are possibly not being used #1099

Open
BethanyBerkowitz opened this issue Jun 20, 2023 · 0 comments
Open
Assignees
Labels
react-native @honeybadger-io/react-native

Comments

@BethanyBerkowitz
Copy link
Contributor

The iosUtils code came from Andrey's original code and I took pains not to mess with how it works. However, in my testing, I've only found backtraces generated using framesFromIOSCallStack. I've never seen an error reported with primaryBackTraceSource = 'ReactNativeComponentStack' or primaryBackTraceSource = 'ReactNativeIOSStackTrace'.

See #1090 (comment) for more detail.

Two main concerns here:

  1. Check if the ReactNativeComponentStack code path is being triggered in dev and how. If so, add a unit test for that, a code comment explaining how it works, and ideally a way to trigger this type of error in at least one of the example projects.
  2. In prod, we are not currently passing to the built-in handler, so errors are only going through the JS handler. We did this to avoid duplicate error reports, but we may be getting less detail than we would otherwise. Check if we are losing detail this way... if so what should we do about that?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
react-native @honeybadger-io/react-native
Projects
None yet
Development

No branches or pull requests

3 participants