Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect error reason when syncing check-ins #223

Closed
stympy opened this issue Jan 2, 2025 · 1 comment · Fixed by #224
Closed

Incorrect error reason when syncing check-ins #223

stympy opened this issue Jan 2, 2025 · 1 comment · Fixed by #224
Assignees

Comments

@stympy
Copy link
Member

stympy commented Jan 2, 2025

We had a customer attempt to sync a check-ins config that had some check-ins using cron scheduling, but their account didn't support that feature, so the API returned an error. The client reported the error as "You have hit your exception rate limit.", which isn't correct.

php artisan honeybadger:checkins:sync

   Honeybadger\Exceptions\ServiceException

  You have hit your exception rate limit.

  at vendor/honeybadger-io/honeybadger-php/src/Exceptions/ServiceException.php:31
     27▕      * @return ServiceException
     28▕      */
     29▕     public static function rateLimit(): self
     30▕     {
  ➜  31▕         return new static('You have hit your exception rate limit.');
     32▕     }
     33▕
     34▕     /**
     35▕      * @return ServiceException

      +20 vendor frames

  21  artisan:13
      Illuminate\Foundation\Application::handleCommand(Object(Symfony\Component\Console\Input\ArgvInput))

Front logo Front conversations

@subzero10
Copy link
Member

@stympy I remember seeing this my self when implementing the integration, but I'm not sure if there was anything I could do from the client side to deduce the real reason for the error (i.e. account not supporting the feature vs rate limit). I'll take another look and come back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants