Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ga): add a new resource to manage access log #6133

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

ruwenqiang123
Copy link
Contributor

What this PR does / why we need it:

Add a new resource to manage access log.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1.support a new resource to manage access log.
2.support related document and acceptance test.

PR Checklist

  • Tests added/passed.
$ make testacc TEST="./huaweicloud/services/acceptance/ga" TESTARGS="-run TestAccAccessLog_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/ga -v -run TestAccAccessLog_basic -timeout 360m -parallel 4
=== RUN   TestAccAccessLog_basic
=== PAUSE TestAccAccessLog_basic
=== CONT  TestAccAccessLog_basic
--- PASS: TestAccAccessLog_basic (203.33s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/ga        203.380s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<
      image
    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<
      image

@ruwenqiang123
Copy link
Contributor Author

$ make testacc TEST="./huaweicloud/services/acceptance/ga" TESTARGS="-run TestAccAccessLog_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/ga -v -run TestAccAccessLog_basic -timeout 360m -parallel 4
=== RUN   TestAccAccessLog_basic
=== PAUSE TestAccAccessLog_basic
=== CONT  TestAccAccessLog_basic
--- PASS: TestAccAccessLog_basic (208.01s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/ga        208.129s

@ruwenqiang123
Copy link
Contributor Author

$ make testacc TEST="./huaweicloud/services/acceptance/ga" TESTARGS="-run TestAccAccessLog_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/ga -v -run TestAccAccessLog_basic -timeout 360m -parallel 4
=== RUN   TestAccAccessLog_basic
=== PAUSE TestAccAccessLog_basic
=== CONT  TestAccAccessLog_basic
--- PASS: TestAccAccessLog_basic (203.86s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/ga        203.905s

@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 6, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 5c7e62e into huaweicloud:master Jan 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants