Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]: srcsets require a height to properly crop images #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Fix]: srcsets require a height to properly crop images #48

wants to merge 1 commit into from

Conversation

ObieMunoz
Copy link

@ObieMunoz ObieMunoz commented Oct 30, 2023 •
edited
Loading

I found an issue where srcsets being generated did not contain the height attribute which means you are unable to crop. I researched the problem and found issue #41 where at least one other user noted the same problem.

This PR resolves #41

[Screenshot before - fit:crop]:
before-crop
[Screenshot after - fit:crop]:
after-crop

@ObieMunoz
Copy link
Author

@hmeissner can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

height parameter missing in srcset
1 participant
@ObieMunoz