Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fast)RawTransactionManager misses constructor accepting both TxSignService & TransactionReceiptProcessor #2117

Open
IvanovVenko opened this issue Nov 26, 2024 · 0 comments
Labels
enhancement a feature request

Comments

@IvanovVenko
Copy link

IvanovVenko commented Nov 26, 2024

Feature description_

The (Fast)RawTransactionManager has a constructor:
public RawTransactionManager(Web3j web3j, TxSignService txSignService, long chainId)
and another one:
public RawTransactionManager( Web3j web3j, Credentials credentials, long chainId, TransactionReceiptProcessor transactionReceiptProcessor)
but misses one that accepts both:
public RawTransactionManager( Web3j web3j, TxSignService txSignService, long chainId, TransactionReceiptProcessor transactionReceiptProcessor)

Haven't dived into the code to investigate if there are good (business or technical) reasons, not to implement it, but on a high level it seems there should not be any.

@IvanovVenko IvanovVenko added the enhancement a feature request label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement a feature request
Projects
None yet
Development

No branches or pull requests

1 participant