Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block catchup for some JSON/RPC providers requires custom evmconnect configuration #1370

Closed
matthew1001 opened this issue Jul 19, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@matthew1001
Copy link
Contributor

matthew1001 commented Jul 19, 2023

A discord discussion (https://discord.com/channels/905194001349627914/1128993021770354728/1128994332150607952) highlighted the fact that it is relatively easy to hit the maximum block request size for some JSON/RPC providers (Alchemy in the case of the above discussion).

One repercussion is that token pool can be left showing incorrect balances due to FireFly being unable to download old blocks (using eth_getLogs). The error message received from Alchemy by evmconnect is Response size is larger than 150MB limit.

The default number of blocks evmconnect requests is 500. The user who reported the issue ^^ said that it needed reducing to 25 in order for FireFly to be able to start the process of catching up with the chain.

It can involve some fairly time-consuming debugging on the part of the user and/or FireFly community to help users identify that this is the reason their token pools aren't showing correct data. It would be good if evmconnect recognised certain types of error case and automatically reduced the (in-memory) value for catchupPageSize until it started receiving blocks.

This won't avoid the slow catch-up time that a low catchupPageSize will cause, but it should mean that the user avoids having to debug what is likely to be a fairly common situation with 3rd party JSON/RPC providers.

@matthew1001 matthew1001 added the enhancement New feature or request label Jul 19, 2023
@matthew1001 matthew1001 self-assigned this Jul 19, 2023
@matthew1001
Copy link
Contributor Author

Possibly related to hyperledger/firefly-evmconnect#26 but they error messages seen in the 2 cases are different

@matthew1001
Copy link
Contributor Author

Fixed by hyperledger/firefly-evmconnect#106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant