Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bulk editing to the /groups/{pubid}/edit page #9145

Open
seanh opened this issue Nov 28, 2024 · 1 comment
Open

Add bulk editing to the /groups/{pubid}/edit page #9145

seanh opened this issue Nov 28, 2024 · 1 comment

Comments

@seanh
Copy link
Contributor

seanh commented Nov 28, 2024

Depends on #9133.

Add bulk editing to the /groups/{pubid}/edit page, so the user can select multiple memberships at once or select all memberships and delete them all in one click

This can be seen in the designs here: https://www.figma.com/design/jon1U01LGSLcx7PWtZ9TPZ/Hypothesis---Group-Management?node-id=2677-127&node-type=canvas&t=WbQZqgZOTMUcskEI-0

@seanh
Copy link
Contributor Author

seanh commented Nov 28, 2024

There's an issue with this when one of the selected members is the user themselves. Do we allow a user to remove multiple members, including themselves, in one click? Do we have to show a different warning dialog if one of the selected users is yourself? Do we make the user's own row not-selectable? But then is that confusing when the select-all button actually selects all rows but one? Related: #9135

I also think the utility of bulk editing is questionable:

I think it's unlikely that anyone is going to want to click the select-all box and remove all of the members of the group (including themselves?) at once: this would completely nuke the group. It might be better not to provide a UI that potentially allows users to do this accidentally.

When removing multiple but not all members from a group, I think bulk editing might not actually save many clicks. To remove three members from the group I would need to:

  1. Click three times to select all three members
  2. Click the Remove 3 members button to remove them

So four clicks total. Whereas without this feature, to remove three members I would need to:

  1. Click the trash icon button next to each one of the three members

So it's actually fewer clicks without this feature!

This is not actually true because when removing members one-by-one the frontend currently shows a confirmation dialog for each member, so it would actually be six clicks. But still--I think the utility of bulk editing is questionable.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant