Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JEH max price and default to 450 #14

Merged
merged 2 commits into from
Sep 14, 2021
Merged

JEH max price and default to 450 #14

merged 2 commits into from
Sep 14, 2021

Conversation

Loscate
Copy link

@Loscate Loscate commented Sep 14, 2021

No description provided.

@vercel
Copy link

vercel bot commented Sep 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/idesys-dev/jeh-maker/7Mxz527ZtmY9DpnrREjtsUUJXrvL
✅ Preview: https://jeh-maker-git-sperrin-idesys-dev.vercel.app

@netlify
Copy link

netlify bot commented Sep 14, 2021

👷 Deploy Preview for jeh-marker-storybook processing.

🔨 Explore the source changes: f4a6c91

🔍 Inspect the deploy log: https://app.netlify.com/sites/jeh-marker-storybook/deploys/6140e01880e90400087fcae9

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #14 (f4a6c91) into master (494c502) will increase coverage by 0.88%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   11.50%   12.38%   +0.88%     
==========================================
  Files          20       20              
  Lines         339      339              
  Branches       26       26              
==========================================
+ Hits           39       42       +3     
+ Misses        299      297       -2     
+ Partials        1        0       -1     
Impacted Files Coverage Δ
src/components/JehMaker.vue 0.00% <ø> (ø)
src/services/optimizePhase.ts 86.66% <100.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 494c502...f4a6c91. Read the comment docs.

@Loscate Loscate changed the title JEH max price and default to 280 JEH max price and default to 450 Sep 14, 2021
@Thykof
Copy link
Member

Thykof commented Sep 14, 2021

Looks good, thank you very much!

@Thykof Thykof merged commit 76d9cf5 into master Sep 14, 2021
@Thykof Thykof mentioned this pull request Sep 14, 2021
@BilelJegham BilelJegham linked an issue Sep 14, 2021 that may be closed by this pull request
@Thykof Thykof deleted the sperrin branch October 4, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to modify max JEH
2 participants