Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed incorrect condition for Low Battery notification #227

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Fixed incorrect condition for Low Battery notification #227

merged 2 commits into from
Oct 6, 2020

Conversation

rahulsuresh-git
Copy link
Contributor

Description

Low battery notification was getting triggered for the same value as set for Full Battery Notification value.

Related Issue

Received low battery notification at 90% battery in default state.

@D0miH D0miH changed the base branch from master to development October 6, 2020 16:55
@D0miH D0miH changed the base branch from development to master October 6, 2020 17:03
@D0miH D0miH changed the base branch from master to development October 6, 2020 17:04
@D0miH D0miH merged commit 19228c6 into iglance:development Oct 6, 2020
@D0miH
Copy link
Member

D0miH commented Oct 6, 2020

Thanks a lot! 👍

@rahulsuresh-git
Copy link
Contributor Author

rahulsuresh-git commented Oct 6, 2020 •
edited
Loading

Happy to help @D0miH 💯
If you don't mind, could you add "hacktoberfest-accepted" label to this PR. That way, it will get counted under my Hacktoberfest contribution towards planting a tree for the good :)

@D0miH
Copy link
Member

D0miH commented Oct 6, 2020

Of course:)

@D0miH
Copy link
Member

D0miH commented Oct 6, 2020

Done. Hope it registered correctly and got counted:)

@rahulsuresh-git
Copy link
Contributor Author

Affirm! It got counted, thanks a ton 👏🏼

@D0miH D0miH linked an issue Oct 11, 2020 that may be closed by this pull request
Low battery notification is delivered on high battery notification value #235
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D0miH D0miH D0miH approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Low battery notification is delivered on high battery notification value
2 participants
@rahulsuresh-git @D0miH