Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitelist: Optimize performance #22

Open
p-offtermatt opened this issue Apr 22, 2024 · 0 comments
Open

Whitelist: Optimize performance #22

p-offtermatt opened this issue Apr 22, 2024 · 0 comments
Labels
priority: nice-to-have Features that are nice to have, but that ultimately should not block deployment.

Comments

@p-offtermatt
Copy link
Member

Right now, the whitelist is potentially costly in terms of gas - when querying the top N proposals and the whitelist has M entries, the complexity of the query is O(N*M).
We likely want to optimize the performance of this query.

Should be done after adding tests (see #21), or we could potentially keep the un-optimized implementation for testing purposes to check that they are equivalent
@p-offtermatt p-offtermatt added the priority: nice-to-have Features that are nice to have, but that ultimately should not block deployment. label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: nice-to-have Features that are nice to have, but that ultimately should not block deployment.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p-offtermatt