Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[combobox] invoker button demo broken (likely due to code change) #2325

Open
tlouisse opened this issue Aug 7, 2024 · 2 comments
Open

[combobox] invoker button demo broken (likely due to code change) #2325

tlouisse opened this issue Aug 7, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@tlouisse
Copy link
Member

tlouisse commented Aug 7, 2024

Expected behavior

When I click on the invoker, the listbox dropdown opens: https://lion-web.netlify.app/components/combobox/use-cases/#invoker-button

Actual Behavior

It does not open. Most likely the cause is inside the code and not in the demo.

When we fix it, we must make sure to add tests for this use case

@tlouisse tlouisse added the bug Something isn't working label Aug 7, 2024
@tlouisse tlouisse changed the title [combobox] invoker button demo broken [combobox] invoker button demo broken (likely due to code change) Aug 7, 2024
@MiB-1
Copy link

MiB-1 commented Aug 17, 2024

Hi @tlouisse , it is opening the listbox dropdown because of the @click event from the stories file.

    @click="${({ currentTarget: el }) => {
      el.opened = !el.opened;
    }}"

do I need to remove and create PR?

@tlouisse
Copy link
Member Author

tlouisse commented Sep 10, 2024

Hi @MiB-1,
the problem is that this click handler was supposed to toggle the dropdown visibility before on button click, but doesn't... (also when the click handler is removed in this demo)

I think this might be introduced here: b50b960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants