Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize NodeStatus with current network interface data by default #23

Open
daniil-berg opened this issue Sep 13, 2024 · 0 comments
Open
Assignees
Labels
breaking change Changes to public functions that are not backwards compatible refactoring Non-breaking changes that improve maintainability or readability

Comments

@daniil-berg
Copy link
Contributor

Instead of calling NetworkInterfaces.update_node_status from the get_status method of the storage/distributor file controller, we can add a pre-root-validator to the NodeStatus model class that gets the NetworkInterface instance and provides default values for the status object from that network interface. This would simplify the get_status methods considerably and make the update_node_status method obsolete.

@daniil-berg daniil-berg self-assigned this Sep 13, 2024
@daniil-berg daniil-berg added breaking change Changes to public functions that are not backwards compatible refactoring Non-breaking changes that improve maintainability or readability labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Changes to public functions that are not backwards compatible refactoring Non-breaking changes that improve maintainability or readability
Projects
None yet
Development

No branches or pull requests

1 participant