-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use github.com/cenkalti/backoff for retries #308
Comments
I can work on this. |
Thanks for working on this! On a phone now and can't remember what was wrong with the current retry system, are you addressing a particular problem that hit you? |
There'd be two main benefits for using this library. First, it would give more control/options over how the backoff is performed (especially with the BackOff interface). Secondly, this backoff library is well tested. |
It doesn't look like this repository has a vendor directory. How would you want to make the dependency on github.com/cenkalti/backoff ? |
I'd just make it without managing it, same as with u-root so far. When u-root is ready we should go to modules? |
@rjoleary Are you looking at this? |
I'll take over this. |
Use github.com/cenkalti/backoff to replace the backoff algorithm in #296.
The backoff package is well tested and gives the user more control over which backoff method and parameters to use.
The text was updated successfully, but these errors were encountered: