Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed ISHPullUpViewController in container #58

Open
iSalah opened this issue Sep 11, 2017 · 4 comments
Open

Embed ISHPullUpViewController in container #58

iSalah opened this issue Sep 11, 2017 · 4 comments

Comments

@iSalah
Copy link

iSalah commented Sep 11, 2017

Hi,

I've downloaded the sample project and tried to integrate the ISHPullUpViewController in a container view with an embed segue.

When I rotate the device, the layout doesn't follow container bounds.
How can I fix this ?

Screenshots below:

Storyboard:
Storyboard

Portrait:
Portrait

Landscape:
Landscape

Thank you,

@felixLam
Copy link
Member

It appears that the containing view itself also does not resize properly as the bottom copyright label is not visible. Can you verify that the containing view resizes properly without the PullUp child VC. Also: you may want to set clipsToBounds to yes on the containing view as the pullup extends beyond its bounds.

@iSalah
Copy link
Author

iSalah commented Sep 12, 2017

Without the PullUp viewcontroller, the main view resizes properly.

I really think there is an issue with orientation change.
When I rotate the device from portrait to landscape, it rotates but breaks the layout.
Then when I rotate back to portrait, nothing happens.

@felixLam
Copy link
Member

Hi @iSalah can you provide a minimal example project to help us reproduce this issue more quickly?

@iSalah
Copy link
Author

iSalah commented Sep 21, 2017

Hi @felixLam
Here is a minimal project based on the sample project.
ISHPullUpSample.zip

You can try to rotate the device, then you can't rotate back (nothing happens).
Hope that helps.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants