CI: Reduce pip behaviour dependencies in test suite #2105
Conversation
chrysle
added
tests
for more information, see https://pre-commit.ci
This reverts commit 2fd6cc6.
This reverts commit bc3f17b.
ncoghlan
changed the title
|
Given CI is green, I agree it isn't necessary to proceed with this. |
ncoghlan
deleted the
issue-2104-avoid-pip-freeze-protection-assumptions
branch
|
@ncoghlan note that the pip version in CI is now restricted so that the updates are transparent. So it is possible that this breaks with newer pips (I know there are some problems; I just don't know if they are the same you were looking to address here). |
ncoghlan
restored the
issue-2104-avoid-pip-freeze-protection-assumptions
branch
|
Ah, in that case you will still need something along these lines when upgrading to a newer pip. The specific changes this made are to:
|
|
This will be an interesting test to see if my changes actually broke compatibility with the older pip version. My prediction: the explicit build system change will be OK, but the protected file list test case will fail (since the older pip still protects those packages) |
| constraints_file.write_text("\n".join(version_constraints)) | ||
| env = os.environ.copy() # Copy entire env to avoid Windows compatibility issues | ||
| # Work around https://github.com/jazzband/pip-tools/pull/1681/files#r1667748889 | ||
| env["PIP_CONSTRAINT"] = str(constraints_file) |
There was a problem hiding this comment.
What if this was to be made conditional? Perhaps, the test could be parametrized with variants before and after certain pip version that would run in different jobs (through the skipif mark). It'd be able to cover the concern of breaking on older versions…
Closes #2104
Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.