Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Layout.width #18

Open
BrunnerLivio opened this issue Jan 21, 2023 · 1 comment · May be fixed by #19
Open

Add Layout.width #18

BrunnerLivio opened this issue Jan 21, 2023 · 1 comment · May be fixed by #19

Comments

@BrunnerLivio
Copy link

First of all; awesome rewrite. I started using this lib 1-2 months ago and I didn't expect TS support and a complete rewrite, big kudos <3

One thing I'd love to access is the layout width, analog to the already existing layout height.

getLayout(...).width
BrunnerLivio added a commit to BrunnerLivio/simple-masonry-layout that referenced this issue Jan 21, 2023
@BrunnerLivio
add Layout.width
cc2fd7a 
resolves jchn#18
@BrunnerLivio BrunnerLivio linked a pull request Jan 21, 2023 that will close this issue
Open
BrunnerLivio added a commit to BrunnerLivio/simple-masonry-layout that referenced this issue Jan 21, 2023
@BrunnerLivio
add Layout.width
3777e61 
resolves jchn#18
@jchn
Copy link
Owner

jchn commented Jan 24, 2023

Hi @BrunnerLivio thanks for the kind words and the pull request!

The reason the width was left out is because it's something you already pass to getLayout but it seems like we're both talking about a different value.

What exactly do you mean by layout width? Is it the width of the layout when the number of columns is greater than the number of items?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add Layout.width BrunnerLivio/simple-masonry-layout
2 participants
@jchn @BrunnerLivio