-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-redirect to localized version #496
Comments
I like the idea, though I'm unsure as to whether I'd like to make |
|
As long as it doesn't add some type of tracking or cookie. I'm fine with it. Also, I'd like the user to maintain the ability to manually change the language to whatever they wish. The redirect should only happen once. |
@AHOHNMYC can you work with these constraints and PR it? :) |
I absolutely share @PyroSamurai's vision about project. But if SEO needs something on main page... To prevent redirect loop, we have to have some sign. I think about bool Or the last thing left: small notification. But to not show it after every page reload, we also have to store some preference~ @tupaschoal now I see only one way to prevent cookies and get single redirect with static Jekyll, but it goes against SEO... |
|
PR #503 was on track to deliver this, but it was abandoned. If anyone wants to pick it up, I'd suggest to start from there :) |
@tupaschoal Do you know/remember what standard was used for the language code renaming? I checked #941 but didn't see any clear direction to follow for that. |
We never did rename the languages, I think, we only dropped the country flags. The current "convention" came from the original repo, so I don't know what was picked |
I propose redirector that will look on
navigator.language
and redirect onjustdeleteme.xyz/{lang}
with fallback to English.It will be easier to handle auto- and manually-generated redirects if
justdeleteme.xyz/
will only handle redirects and the English version will be onjustdeleteme.xyz/en
.Working example: chuyu.me (sources)
The text was updated successfully, but these errors were encountered: