Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laravel 9 default lang directory has moved #151

Open
effeks opened this issue Jan 25, 2023 · 1 comment
Open

Laravel 9 default lang directory has moved #151

effeks opened this issue Jan 25, 2023 · 1 comment

Comments

@effeks
Copy link
Contributor

effeks commented Jan 25, 2023

Hey!

Not a bug, more of a heads-up.

Please note that in Laravel 9 /resources/lang has moved to just /lang. If I'm not mistaken this package installs to the old path still, which potentially creates confusion for Laravel and/or the developer, because they might re-create / create the old /resources/lang directory again which Laravel will then start to use.

See for example https://stackoverflow.com/questions/71084830/laravel-9-app-upgraded-from-8-lang-directory-not-working-as-expected for more details.
@jeremykenedy
Copy link
Owner

Can you make a pr and I will approve. Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeremykenedy @effeks