Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes to master #128

Open
ellert opened this issue Apr 1, 2014 · 1 comment
Open

Merge changes to master #128

ellert opened this issue Apr 1, 2014 · 1 comment

Comments

@ellert
Copy link
Contributor

ellert commented Apr 1, 2014

Hi!

There seems to be a few commits that were only done in the 2.0.5 or 2.0.6 branches that were never merged into the 2.0 branch. And not all changes to the 2.0 branch were merged in the master. (The release notes for 2.0.6 only exists in the 2.0.6 branch and were never merged to 2.0 and master for examples, and there are others.) This is a consequence of the previous "fix in release branch then merge to master" workflow which was not always carried out to the end. We have since decided to change to a "fix in master then merge to release branch" workflow, which will avoid this problem, but some of the old sins needs to be taken care of.

It would be a pity if making a release from the master branch would reintroduce problems that were already fixed in some 2.x branch.

Can someone merge or cherrypick the relevant 2.0.5/2.0.6 changes (which should be most of them except for those that only massage the version number) to 2.0 and then merge or cherrypick the relevant 2.0 changes to master. (When merging to master from other branches be careful not to reintroduce dos line endings - this already happened once.)

@ellert ellert changed the title Merge chenges to master Merge changes to master Apr 1, 2014
@kofemann
Copy link
Member

kofemann commented Apr 1, 2014

Hi Mathias,

you are absolutely right. We have to fix this situation. If you have some commits int the mibd just let me know and I will cherry-pick them into master as well.

Thanks,
Tigran.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants