From 48d54cf78638bde527ef21202b53ad9446ff5185 Mon Sep 17 00:00:00 2001
From: laushunyu <nikolas.syliu@gmail.com>
Date: Mon, 1 Jul 2024 18:55:13 +0800
Subject: [PATCH] fix: failed valuer convert returning unexpected true pick

---
 copier.go | 31 ++++++++++++++++++++++---------
 1 file changed, 22 insertions(+), 9 deletions(-)

diff --git a/copier.go b/copier.go
index 0cc6465..d030702 100644
--- a/copier.go
+++ b/copier.go
@@ -610,9 +610,14 @@ func set(to, from reflect.Value, deepCopy bool, converters map[converterPair]Typ
 		}
 	}
 
+	// try convert directly
 	if from.Type().ConvertibleTo(to.Type()) {
 		to.Set(from.Convert(to.Type()))
-	} else if toScanner, ok := to.Addr().Interface().(sql.Scanner); ok {
+		return true, nil
+	}
+
+	// try Scanner
+	if toScanner, ok := to.Addr().Interface().(sql.Scanner); ok {
 		// `from`  -> `to`
 		// *string -> sql.NullString
 		if from.Kind() == reflect.Ptr {
@@ -627,10 +632,13 @@ func set(to, from reflect.Value, deepCopy bool, converters map[converterPair]Typ
 		// string -> sql.NullString
 		// set `to` by invoking method Scan(`from`)
 		err := toScanner.Scan(from.Interface())
-		if err != nil {
-			return false, nil
+		if err == nil {
+			return true, nil
 		}
-	} else if fromValuer, ok := driverValuer(from); ok {
+	}
+
+	// try Valuer
+	if fromValuer, ok := driverValuer(from); ok {
 		// `from`         -> `to`
 		// sql.NullString -> string
 		v, err := fromValuer.Value()
@@ -644,16 +652,21 @@ func set(to, from reflect.Value, deepCopy bool, converters map[converterPair]Typ
 		rv := reflect.ValueOf(v)
 		if rv.Type().AssignableTo(to.Type()) {
 			to.Set(rv)
-		} else if to.CanSet() && rv.Type().ConvertibleTo(to.Type()) {
+			return true, nil
+		}
+		if to.CanSet() && rv.Type().ConvertibleTo(to.Type()) {
 			to.Set(rv.Convert(to.Type()))
+			return true, nil
 		}
-	} else if from.Kind() == reflect.Ptr {
-		return set(to, from.Elem(), deepCopy, converters)
-	} else {
 		return false, nil
 	}
 
-	return true, nil
+	// from is ptr
+	if from.Kind() == reflect.Ptr {
+		return set(to, from.Elem(), deepCopy, converters)
+	}
+
+	return false, nil
 }
 
 // lookupAndCopyWithConverter looks up the type pair, on success the TypeConverter Fn func is called to copy src to dst field.