chrony templates: always use debian pool

[mika]

The chrony templates use:

# Use Debian vendor zone.
pool 2.debian.pool.ntp.org iburst
[...]
{% if base_ntp_server is defined %}
# Set NTP server which can be used as a time source (server),
# prefer this source over sources without the prefer option (prefer) an
# start with a burst of 4-8 requests in order to make the first update of the clock sooner (iburst)
server {{ base_ntp_server }}
#
{% endif %}

IMO this isn't expected behavior, as then the Debian pool always gets used, even if base_ntp_server is set to a custom server.

I'd assume something like this:

{% if base_ntp_server is defined %}
# Set NTP server which can be used as a time source (server),
# prefer this source over sources without the prefer option (prefer) an
# start with a burst of 4-8 requests in order to make the first update of the clock sooner (iburst)
server {{ base_ntp_server }}
{% else %}
# Use Debian vendor zone.
pool 2.debian.pool.ntp.org iburst
{% endif %}

Happy to provide a PR if you agree.

[jkirk]

Hmm, yeah... I also regularly stumble across these lines, but tell myself that the Debian NTP pool is trustworthy and can "always" be used (even if server (with base_ntp_server) is set). 🙈

So yes, your proposal is fine for me (if you think we should get rid of the Debian NTP pool, if we have a server set). Thx!