Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default application credentails for Dialogflow instead of insecure private key #1317

Open
1 of 4 tasks
Mistic92 opened this issue May 9, 2022 · 0 comments
Open
1 of 4 tasks

Comments

@Mistic92
Copy link

Mistic92 commented May 9, 2022

I'm submitting a...

  • Bug report
  • Feature request
  • Documentation issue or request
  • Other... Please describe:

Expected Behavior

When using Dialogflow NLU or just integration, there should be used so called Default Application Credentials instead of insecure service account key.
This can be set localy just using gcloud and on GCP it is provided by runtime environment. Also google-auth-library handle environment variable GOOGLE_APPLICATION_CREDENTIALS by itself to no jwt should be used in that explicit way.

Issue is in v4 and v3 in this lines https://github.com/jovotech/jovo-framework/blob/v4/dev/integrations/nlu-dialogflow/src/DialogflowNlu.ts#L89

Current Behavior

Requirement of generating json key which is not secure practice.

Error Log

If you have an error log, please paste it here.

Your Environment

  • Jovo Framework version used: 4.x.x 3.x.x
  • Operating System:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants