-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: Order is not found/filled | Order is actually Filled | Repeat Multiple Orders | After dYdX Chain outage and subsequent Upgrade #30
Comments
thank you for raising issue Although I have not experienced this issue since yesterday, but I've modified await _sleep() to I'll monitor if this is more stable configuration |
That restart must have helped, or maybe the validators needed some time to get up to speed/sync again, not sure. I still don't know what in the code would have failed and allowed or triggered all the duplicate orders that happened before, my suspicion is it was a validator failure outside the control of the code to check. Here's my most recent results: I'm going to test with I'm going to wait for one more signal and follow up with results, to confirm it's no longer placing multiple trades. |
nice! thank you for the detailed report |
Hello, I experienced a major bug yesterday after a trade was triggered post dYdX Chain outage and subsequent dYdX Chain 4.0.2 (or 4.0.4) upgrade yesterday.
https://status.dydx.trade/
I had multiple
Error: Order is not found/filled. Retry again, count:
counting all the way up to maximum in terminal.The problem is all those orders were filled, and placed multiple times! This resulted in being extremely over leveraged from what TV signal
size
was. Thankfully I noticed it only a couple hours post trade. I checked the dYdX Trade History and confirmed all the same orders that supposedly Errored were actually placed successfully, but multiple times!I think the logic used to check for a Filled trade has been broken since the Chain upgrade.
I've since modified dydx_v4
createOrder.ts
line 34maxTries
to1
and line 56await _sleep
to60000
. This way only one attempt will be made.After making the code changes above, I've since restarted with
Ctrl-C
, andyarn start
in terminal, so we wait and see.I will check back after another signal to see if it shows it a successful
dYdX v4 Order ID: xxxxxxxx-...
in terminal, like it used to.Let me know if you or anyone else has experienced this, and check your positions after any recent trades post the dYdX Chain outage.
The text was updated successfully, but these errors were encountered: