Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prolog language syntax highlighting #1715

Open
choldgraf opened this issue Jan 4, 2025 · 1 comment
Open

Prolog language syntax highlighting #1715

choldgraf opened this issue Jan 4, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@choldgraf
Copy link
Collaborator

Prolog is a language that traditionally had support in Jupyter Book 1, but does not seem to have support in Jupyter Book 2

Here's a sandbox example showing non-highlighted syntax

References

@agoose77
Copy link
Contributor

agoose77 commented Jan 6, 2025

It seems like the highlight.js backend for our existing react-syntax-highlighter integration isn't tokenizing as deeply as I'd expect. Consequently, the highlighted code is very plain.

In myst-theme, we have to maintain some annoying custom CSS to deal with the way that react-syntax-highlighter works in relation to SSR theme switching. It looks like using shiki would make that easier. Shiki also supports prolog nicely out of the box, perhaps we should close this bug by addressing #1683.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants