Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional send_count parameter to collectives #336

Closed
Hespian opened this issue Jun 15, 2022 · 5 comments
Closed

Add optional send_count parameter to collectives #336

Hespian opened this issue Jun 15, 2022 · 5 comments

Comments

@Hespian
Copy link
Member

Hespian commented Jun 15, 2022

Right now all operations seem to just send all data they get in their send buffer. Sometimes you may want to send only a part of that. Right now the only possibility to do so would be with a span.

@kurpicz
Copy link
Member

kurpicz commented Jun 15, 2022

For me this seems to be more of a feature than a bug. We have simple syntax to send any interval of the data (span) or the whole buffer (nothing needs to be added). I am not sure a send_count parameter is simpler. However, I have no hard feelings w.r.t. adding a send_count parameter.

@Hespian
Copy link
Member Author

Hespian commented Jun 15, 2022

Maybe you are right and this would just bloat KaMPIng without adding much. Maybe we can just postpone this until we actually implement stuff in KaMPIng and see that it would actually be useful

@niklas-uhl
Copy link
Member

niklas-uhl commented Jun 17, 2022

It would also prefer using span for this. This is conceptually in line with #301. At the moment its a bit awkward to create a span, maybe we just add helpers for that and we're fine. Something like:

std::vector<int> v = { ... };
comm.send(send_buf(make_subview(v, 0, 32)), rank(1));  //make subview returns a span

@lukashuebner
Copy link
Member

Imho, that's overly verbose, which is something we explicitly decided that we're trying to avoid. I'm strongly pro send_count.

@niklas-uhl
Copy link
Member

This should be closed by #118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants