Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descheduling support for FlinkDeployments #5987

Open
deefreak opened this issue Dec 27, 2024 · 6 comments
Open

Descheduling support for FlinkDeployments #5987

deefreak opened this issue Dec 27, 2024 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@deefreak
Copy link

What would you like to be added:
Currently, the descheduler only supports Deployment objects.
For our use case, we wanted to support FlinkDeployments and for that I have done changes and it has been working fine in our environment.

Why is this needed:
This is needed so that descheduler can support FlinkDeployments and reschedules it to other clusters if flinkdeployment pods are unschedulable.

I would like to contribute for this feature.

@deefreak deefreak added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 27, 2024
@XiShanYongYe-Chang
Copy link
Member

Hi @deefreak thanks for your feedback!

For our use case, we wanted to support FlinkDeployments and for that I have done changes and it has been working fine in our environment.

What are your main changes? Can you explain them briefly?

@deefreak
Copy link
Author

deefreak commented Dec 28, 2024

Hi @XiShanYongYe-Chang two changes are required:

  1. Add flinkdeployment gvk here
  2. As descheduler tries to get number of unschedulable pods and decide on rescheduling,
    I added a case for FlinkDeployments here.
    As FlinkDeployments have jobManager and taskManager pods, we need to list both of them and check if any pod is unschedulable in the same way we are doing for deployment object.

@XiShanYongYe-Chang
Copy link
Member

Thanks @deefreak for your quick response.

Would you like to share it at a community meeting?

@deefreak
Copy link
Author

@XiShanYongYe-Chang sure.

@deefreak
Copy link
Author

@XiShanYongYe-Chang We will have this meeting on 6th January 2025? Should I add it in the document of the community meeting?

@XiShanYongYe-Chang
Copy link
Member

We will have this meeting on 6th January 2025?

Yes, we will

Should I add it in the document of the community meeting?

Yes, you can do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: No status
Development

No branches or pull requests

2 participants