Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command/pr, command/list: When the latest commit is not mergeable, tctest should return an error #34

Open
gdavison opened this issue Jun 30, 2020 · 0 comments

Comments

@gdavison
Copy link
Contributor

gdavison commented Jun 30, 2020

If the latest commit is not mergeable, tctest will identify tests from the latest mergeable commit. It would be helpful if the pr and list commands would return an error stating that the current PR is not mergeable.

A flag to override this behaviour should be added, which would emit a warning and continue running the command.

Steps to reproduce:

  1. On a project with status checks configured, introduce an error, e.g. a linting error
  2. Run tctest pr
  3. Observe TeamCity running old tests

Proposed behaviour:

$ tctest pr 12345
Discovering tests for pr #12345 (...)
ERROR: PR #12345 is not mergeable
$tctest pr 12345 --ignore-mergeability
Discovering tests for pr #12345 (...)
WARNING: PR #12345 is not mergeable, using last mergeable commit ab3410
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant