Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command/pr, command/list: Fails if a file is deleted when building list of tests #50

Closed
gdavison opened this issue Nov 27, 2020 · 3 comments

Comments

@gdavison
Copy link
Contributor

When running the tctest pr <pr number> or tctest list <pr numberr> commands on a PR which deletes a file, it fails with the following error

$ tctest pr 16467
Discovering tests for pr #16467 (https://github.com/terraform-providers/terraform-provider-aws/pull/16467)...
ERRO[2020-11-27 11:19:24] tctest: pr cmd failed: pr list failed: downloading file (aws/internal/tfawsresource/testing_test.go) metadata: GET https://api.github.com/repositories/93444615/contents/aws/internal/tfawsresource/testing_test.go?ref=e9457fd5f715fc381621b558e33018cf7cec0119: 404 Not Found [] 

If the user provides a test regex, it does not fail

tctest pr 16467 TestAccDataSourceAwsRoute53ResolverRules_basic
triggering refs/pull/16467/merge for TestAccDataSourceAwsRoute53ResolverRules_basic...
  build 12345 queued: https://teamcity.example.com/viewQueued.html?itemId= 12345
@katbyte
Copy link
Owner

katbyte commented Jan 3, 2021

This might be fixed on master now @gdavison

@katbyte
Copy link
Owner

katbyte commented Jan 3, 2021

duplicate of #17 ?

@katbyte
Copy link
Owner

katbyte commented Aug 4, 2022

closing as duplicate of #17

@katbyte katbyte closed this as completed Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants