Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor open_new_blocks #505

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Refactor open_new_blocks #505

merged 2 commits into from
Dec 13, 2024

Conversation

digitalmoksha
Copy link
Collaborator

An attempt to refactor open_new_blocks a little, to help in reading the code.

@kivikakk let me know if you're ok with something like this. I wouldn't think it would affect performance too much. Let's see if our built-in benchmark has numbers.

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Command Mean [ms] Min [ms] Max [ms] Relative
./bench.sh ./comrak-cd8d884 313.1 ± 1.2 311.9 318.4 2.87 ± 0.02
./bench.sh ./comrak-main 314.5 ± 5.8 311.1 341.7 2.88 ± 0.06
./bench.sh ./pulldown-cmark 109.2 ± 0.8 108.0 111.0 1.00
./bench.sh ./cmark-gfm 117.2 ± 0.6 116.5 118.3 1.07 ± 0.01
./bench.sh ./markdown-it 468.9 ± 0.8 467.6 471.1 4.29 ± 0.03

Run on Thu Dec 12 21:57:54 UTC 2024

@digitalmoksha
Copy link
Collaborator Author

/run-bench

Copy link
Owner

@kivikakk kivikakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, happy to clean this up :)

@digitalmoksha digitalmoksha merged commit 0bdd26d into main Dec 13, 2024
38 checks passed
@digitalmoksha digitalmoksha deleted the bw-refactor-open-new-blocks branch December 13, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants