Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to read ZIM when launch from Parrallels Desktop Profile Shared Folder #1267

Open
rgaudin opened this issue Dec 5, 2024 · 14 comments · May be fixed by #1313
Open

Not able to read ZIM when launch from Parrallels Desktop Profile Shared Folder #1267

rgaudin opened this issue Dec 5, 2024 · 14 comments · May be fixed by #1313
Assignees
Milestone

Comments

@rgaudin
Copy link
Member

rgaudin commented Dec 5, 2024

When launched from a network drive Parrallels Desktop Profile Shared Folder (aka a shared folder which to Apps appear to be a regular C:\Mac prefixed folder), clicking Open on a ZIM opens a new tab with the correct Icon but that tab is blank.
Very first time I clicked + for a new tab I got an error message which makes me doubt #1236 is completely fixed.

Image

I dont want to open a general ticket but I think the person fixing this should test the overall behavior of the app after fixing it…

@kelson42
Copy link
Collaborator

kelson42 commented Dec 6, 2024

Indeed, exactly the same as #885

@veloman-yunkan
Copy link
Collaborator

Could not reproduce with the 2024-12-06 nightly build extracted into a samba shared folder in an Ubuntu 22.04 virtual machine.

@rgaudin
Copy link
Member Author

rgaudin commented Dec 6, 2024

It's the same with this build on my Windows 11 VM

@veloman-yunkan
Copy link
Collaborator

Is it because of the Windows version? Mine is Windows 10 (Pro).

@veloman-yunkan
Copy link
Collaborator

BTW, is the confirmation box about running kiwix-desktop from a remote disk/network folder displayed in your case?

@rgaudin
Copy link
Member Author

rgaudin commented Dec 6, 2024

Never seen that dialog box.

@veloman-yunkan
Copy link
Collaborator

Then the problem is that the path of your kiwix-desktop is not recognized as a remote location/network path. What does it look like?

@rgaudin
Copy link
Member Author

rgaudin commented Dec 7, 2024

Indeed the VM engine I'm using implemented a trick to prevent those apparently common shared-folder issue… creating this one.

See https://kb.parallels.com/130138

I'm not sure there's much we can do.

@veloman-yunkan
Copy link
Collaborator

veloman-yunkan commented Dec 8, 2024

I think that the title and description of this ticket must be updated so that the problem reported doesn't appear much more general than it actually is. Also I believe that at this stage we shouldn't spend any effort fixing issues caused by interoperability between different components of heterogeneous systems (at least when, like in this case, there is a workaround - don't run kiwix-desktop from a shared folder, copy it to your local machine instead).

@kelson42
Copy link
Collaborator

kelson42 commented Dec 8, 2024

I don't fully get the problem, but postponing.

@kelson42 kelson42 modified the milestones: 2.4.0, 2.5.0 Dec 8, 2024
@rgaudin rgaudin changed the title Not able to read ZIM when launch from network drive Not able to read ZIM when launch from Parrallels Desktop Profile Shared Folder Dec 9, 2024
@rgaudin
Copy link
Member Author

rgaudin commented Dec 9, 2024

Edited. I'll report it to Parallels as well.

@kelson42
Copy link
Collaborator

@rgaudin Do we have an upstream Parallels bug link to share here?
@veloman-yunkan Do we have a way to react based on the exception triggered by QtWebBrowser?

If we can not handle the exception properly, I don't really see a way to identify the problem upfront. Therefore I propose to properly document the QTWEBENGINE_CHROMIUM_FLAGS="--no-sandbox" workaround via env. variable and create a .bat file allowing to do that easily. That would be an acceptable workaround IMHO.

@rgaudin
Copy link
Member Author

rgaudin commented Dec 30, 2024

Actually, I don't think we should open a ticket upstream as the option is well explained in the doc and a regular shared-folder can be used instead in the options.

I tried and I do get the expected popup about the sandbox.

What we could do is if we can detect the issue, is check whether ran off C:\Mac (which is static home for those special shared folders) and display a dedicated error message.

At this stage, with only myself reporting this, it might not be worth it.

@kelson42
Copy link
Collaborator

@rgaudin If I understand properly your last comment, these Parallels Desktop shared folder paths always start with C:\Mac. This is IMHO "unique" enough so we handle it exactly like network drive paths starting with //. Seems to me a good enough fix without requiring serious reenginering... something which might be too much of an effort for such a niche use case! Does that sound reasonable?

@kelson42 kelson42 self-assigned this Dec 31, 2024
@kelson42 kelson42 linked a pull request Dec 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants