enable preparer interface to pre operations #964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Batuhan Apaydın <[email protected]>
developer-guy
force-pushed
the
feature/539
branch
from
8011e9f to
e4881ae
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #964 +/- ##
==========================================
- Coverage 52.42% 52.02% -0.40%
==========================================
Files 43 43
Lines 3325 3350 +25
==========================================
Hits 1743 1743
- Misses 1353 1377 +24
- Partials 229 230 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
imjasonh
reviewed
Feb 23, 2023
| return err | ||
| } | ||
|
|
||
| if err := remote.CheckPushPermission(tag, d.keychain, d.t); err != nil { |
There was a problem hiding this comment.
This isn't going to handle d.insecure, unfortunately... 🤔
|
This Pull Request is stale because it has been open for 90 days with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #539 also duplicates #951
PTAL @imjasonh