#66 - feat: allow to skip all deps #124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaporalDead
changed the title
CaporalDead
changed the title
|
Great, looking forward, suggestions seems fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
For now, we can only ignore implicit dependencies. While auditing many repositories, it pushes the app sources and its dependencies that may result in duplicate reports.
Closes #66
What is the new behavior?
This PR allows us to ignore all project dependencies.
Does this PR introduce a breaking change?
Other information
I made it simple but I think a better way to implement this would be to use an enum like this :
Also, as the getDependentPackagesForProject function is internal, without modifying a bunch of code, I couldn't test the branch properly