Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WARN: Excessive number of pending callbacks: 501 #13

Closed
GuglielmoFelici opened this issue Jan 5, 2024 · 5 comments
Closed

WARN: Excessive number of pending callbacks: 501 #13

GuglielmoFelici opened this issue Jan 5, 2024 · 5 comments

Comments

@GuglielmoFelici
Copy link

Hello! First of all, thanks for this library, it's awesome! 🚀
When using it in a react native app with Expo, I get the following warning on boot. The library works fine, but this warning seems to suggest some leak. Please let me know if I can help in any way to fix this!

WARN  Please report: Excessive number of pending callbacks: 501. 
Some pending callbacks that might have leaked by never being called from native code: 
{
 "186": { "module": "NativeAnimatedModule", "method": "startAnimatingNode" },
 "336": { "module": "NativeAnimatedModule", "method": "startAnimatingNode" },
 "352": { "module": "NativeAnimatedModule", "method": "startAnimatingNode" },
 "3810": { "module": "NativeAnimatedModule", "method": "startAnimatingNode" },
 "3825": { "module": "NativeAnimatedModule", "method": "startAnimatingNode" },
... 
RatingSymbol@http://192.168.1.66:19000/node_modules/expo/AppEntry.bundle?platform=android&dev=true&hot=false:191284:20

(it goes on for quite a while). Full log:
rating-warning.log

This is how I use it in my code:

export const RistoRating = ({
  rating,
  onChange,
  readonly = true
}: RistoRatingProps) => {
  return (
    <View>
      <Rating
        size={25}
        rating={rating / 2}
        onChange={onChange}
        disabled={readonly}
      />
    </View>
  )
}

Thanks in advance for your help!

@kolking
Copy link
Owner

kolking commented Jan 7, 2024

Hi Guglielmo! I've tried to create a new expo (v. 49) app and used the same testing code I've provided in #14 (comment). Didn't notice any warnings or anything else unusual in the logs. Most likely, the warnings are caused by something else rather that the rating module itself.

The way you're using the rating module in your code looks fine to me, but this doesn't provide the full picture. There could be a parent component(s) at some level that cause the warning.

@kolking
Copy link
Owner

kolking commented Jan 7, 2024

Btw, this issue looks very similar. If this is the case, then you can probably try to upgrade to the latest expo (v. 49) which is paired with react-native 0.72.6

@GuglielmoFelici
Copy link
Author

I'm already at 49.0.21 with react native 0.72.6. By the looks of the issue you linked, it's seems like some bug with react native and not your library, even if the warning is raised by RatingSymbol. I'll try to reproduce in a minimal example

@GuglielmoFelici
Copy link
Author

I managed to track down the issue to a weird interaction with KittenUI, I think it's on their/RN side. Sorry for the noise and thanks for trying to reproduce!

@GuglielmoFelici GuglielmoFelici closed this as not planned Won't fix, can't repro, duplicate, stale Jan 7, 2024
@kolking
Copy link
Owner

kolking commented Jan 7, 2024

@GuglielmoFelici no worries! And good luck with the application you're building!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants