Consolidate Kubeflow tests #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansinikarunarathne
force-pushed
the
organize_kubeflow_tests
branch
from
75789b6 to
ee570fb
Compare
hansinikarunarathne
force-pushed
the
organize_kubeflow_tests
branch
from
ee570fb to
b84f222
Compare
|
The goal is consolidate, reduce compexity and the amount of files. We still have as many files as before and it is only adjusted for one higher level workflow. |
|
|
||
| # Create KinD Cluster | ||
| echo "Creating KinD Cluster..." | ||
| if ! kind create cluster --config tests/gh-actions/kind-cluster.yaml; then |
There was a problem hiding this comment.
Can we inline all three scripts to save 3 additional files?
There was a problem hiding this comment.
I have addressed this. Can you check it? Let me know if you have any concerns.
If not I can delete those redundant files and update the PR. j
Just in the end we have to merge it together.
7 tasks
hansinikarunarathne
force-pushed
the
organize_kubeflow_tests
branch
from
e8938f7 to
c7e3bf9
Compare
| run: ./tests/gh-actions/install_kustomize.sh | ||
| - name: Install KinD, Create KinD cluster and Install kustomize | ||
| run: | | ||
| chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh |
There was a problem hiding this comment.
no chmod here, you need to fix the file in git itself
There was a problem hiding this comment.
I fixed this. If you have any concerns regarding this PR can you let me know? If not I can delete redundant files before the merge
* Expose Ray and Seldon to example kustomization.yaml file Signed-off-by: hansinikarunarathne <[email protected]> * Add internal documentations for ray and seldon Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]>
Signed-off-by: hansinikarunarathne <[email protected]>
Signed-off-by: hansinikarunarathne <[email protected]>
… 2400s Signed-off-by: hansinikarunarathne <[email protected]>
Signed-off-by: hansinikarunarathne <[email protected]>
Signed-off-by: hansinikarunarathne <[email protected]>
Signed-off-by: hansinikarunarathne <[email protected]>
Signed-off-by: hansinikarunarathne <[email protected]>
…kubeflow#2819) * Patched PSS labels to multi_tenancy Signed-off-by: biswajit-9776 <[email protected]> * Added script in gh-actions to patch PSS/static/baseline/pacthes Signed-off-by: biswajit-9776 <[email protected]> * Added PSS scripts for both baseline and restricted labels of static namespaces and renamed directories Signed-off-by: biswajit-9776 <[email protected]> * Added tests to enable PSS in gh-actions Signed-off-by: biswajit-9776 <[email protected]> * Added workflow test for PSS labels Signed-off-by: biswajit-9776 <[email protected]> * Fixed indentation Signed-off-by: biswajit-9776 <[email protected]> --------- Signed-off-by: biswajit-9776 <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]>
hansinikarunarathne
force-pushed
the
organize_kubeflow_tests
branch
from
58ad7ee to
d925710
Compare
Signed-off-by: hansinikarunarathne <[email protected]>
Signed-off-by: hansinikarunarathne <[email protected]>
| - tests/gh-actions/install_istio.sh | ||
| - tests/gh-actions/install_cert_manager.sh | ||
| - common/cert-manager/** | ||
| - common/oauth2-proxy/** | ||
| - common/oidc-client/oauth2-proxy/** |
There was a problem hiding this comment.
Do we have common/oidc-client/oauth2-proxy that's replacing common/oauth2-proxy in the paths here?
There was a problem hiding this comment.
We have common/oauth2-proxy
|
From my end, I ran the latest failing build, and the failing step "Create Kubeflow Notebook with PodDefaults" ran in 300s locally at my end. Only difference I made was creating the cluster using the configuration present in master https://github.com/kubeflow/manifests/blob/master/tests/gh-actions/kind-cluster.yaml instead of this PR. I believe there's something here in Github Actions that's causing this particular fail in this and other PRs. |
|
Again, can you provide more information? The pipeline creates a notebook resource, but it won't be in the ready state: kubectl describe Notebook -n kubeflow-user-example-com testAdd this in the file which executes "Create Pipeline Run from Kubeflow Notebook" |
|
Maybe something regarding caching changed, maybe there are pull rate limits. But I need debugging enabled for more insights. |
|
Yes you are right that's why I want to describe the resource |
| @@ -69,7 +61,7 @@ jobs: | |||
| kubectl apply -f tests/gh-actions/kf-objects/notebook.test.kubeflow-user-example.com.yaml | |||
There was a problem hiding this comment.
@hansinikarunarathne after line 61, would be suitable to add the following command before the wait command:
kubectl describe Notebook -n kubeflow-user-example-com testThere was a problem hiding this comment.
You can also try this separately in your own PR, this way you can both experiment at the same time.
There was a problem hiding this comment.
Yes, I will make a PR to push my change for the cronjob meanwhile.
|
@hansinikarunarathne it seems to have been a github issue... /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7 tasks
hansinikarunarathne
added a commit
to hansinikarunarathne/kubeflow-manifests
that referenced
this pull request
Aug 26, 2024
* Training operator CICD improvements (kubeflow#2779) * Add the networkpolicies Signed-off-by: juliusvonkohout <[email protected]> * rework the training operator tests Signed-off-by: juliusvonkohout <[email protected]> * fix the comments Signed-off-by: juliusvonkohout <[email protected]> * fix filename Signed-off-by: juliusvonkohout <[email protected]> * try to fix the permissions Signed-off-by: juliusvonkohout <[email protected]> * try to fix the permissions Signed-off-by: juliusvonkohout <[email protected]> * change to the user namespace Signed-off-by: juliusvonkohout <[email protected]> * update the image to rc.1 Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> --------- Signed-off-by: juliusvonkohout <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * create seperate file for install_KinD_create_KinD_cluster_install_kustomize.sh to avoid code repitition Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * make sh file executable Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * remove reduntant codes Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * combine kind, kuztomize and kind-cluster create sh files into one file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix issues with combined file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix configurations issues Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix linting issues in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix trailing issues in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix trailing issues in workflow file bentoml Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh executable and removed chmod command from the workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made modifications in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * deleted redundant files from tests folder Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Add kustomize installation file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made install_kustomize.sh file executable Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made a fix Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix issue with linting of YAML files (kubeflow#2825) * fix issue with linting of YAML files Signed-off-by: hansinikarunarathne <[email protected]> * delete a file to check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add the after checking the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add folders to yaml linting Signed-off-by: hansinikarunarathne <[email protected]> * check linting issues Signed-off-by: hansinikarunarathne <[email protected]> * check linting issues Signed-off-by: hansinikarunarathne <[email protected]> * check linting changes Signed-off-by: hansinikarunarathne <[email protected]> * check linting functionality by chnaging different files Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add github, hack and tests folders also for linting Signed-off-by: hansinikarunarathne <[email protected]> * Check functionality by deleting sh from hack and yaml file common Signed-off-by: hansinikarunarathne <[email protected]> * Added deleted files Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Expose Ray and Seldon to example kustomization.yaml file (kubeflow#2834) * Expose Ray and Seldon to example kustomization.yaml file Signed-off-by: hansinikarunarathne <[email protected]> * Add internal documentations for ray and seldon Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Increase the time out of notebook and katib test Signed-off-by: hansinikarunarathne <[email protected]> * increase the timout time Signed-off-by: hansinikarunarathne <[email protected]> * increase timeout of the create pipeline Run from Kubeflow Notebook to 2400s Signed-off-by: hansinikarunarathne <[email protected]> * Add code to calculate time taken to pull a docker image Signed-off-by: hansinikarunarathne <[email protected]> * fix syntax error in yaml file Signed-off-by: hansinikarunarathne <[email protected]> * increase pipeline time Signed-off-by: hansinikarunarathne <[email protected]> * remove one step in action Signed-off-by: hansinikarunarathne <[email protected]> * Added tests to tests/gh-actions to enable baseline and restricted PSS (kubeflow#2819) * Patched PSS labels to multi_tenancy Signed-off-by: biswajit-9776 <[email protected]> * Added script in gh-actions to patch PSS/static/baseline/pacthes Signed-off-by: biswajit-9776 <[email protected]> * Added PSS scripts for both baseline and restricted labels of static namespaces and renamed directories Signed-off-by: biswajit-9776 <[email protected]> * Added tests to enable PSS in gh-actions Signed-off-by: biswajit-9776 <[email protected]> * Added workflow test for PSS labels Signed-off-by: biswajit-9776 <[email protected]> * Fixed indentation Signed-off-by: biswajit-9776 <[email protected]> --------- Signed-off-by: biswajit-9776 <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * add kind cluster step into pss test yaml file Signed-off-by: hansinikarunarathne <[email protected]> * change time pot time Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: juliusvonkohout <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: biswajit-9776 <[email protected]> Co-authored-by: Julius von Kohout <[email protected]> Co-authored-by: biswajit-9776 <[email protected]>
hansinikarunarathne
added a commit
to hansinikarunarathne/kubeflow-manifests
that referenced
this pull request
Aug 26, 2024
* Training operator CICD improvements (kubeflow#2779) * Add the networkpolicies Signed-off-by: juliusvonkohout <[email protected]> * rework the training operator tests Signed-off-by: juliusvonkohout <[email protected]> * fix the comments Signed-off-by: juliusvonkohout <[email protected]> * fix filename Signed-off-by: juliusvonkohout <[email protected]> * try to fix the permissions Signed-off-by: juliusvonkohout <[email protected]> * try to fix the permissions Signed-off-by: juliusvonkohout <[email protected]> * change to the user namespace Signed-off-by: juliusvonkohout <[email protected]> * update the image to rc.1 Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> --------- Signed-off-by: juliusvonkohout <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * create seperate file for install_KinD_create_KinD_cluster_install_kustomize.sh to avoid code repitition Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * make sh file executable Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * remove reduntant codes Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * combine kind, kuztomize and kind-cluster create sh files into one file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix issues with combined file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix configurations issues Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix linting issues in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix trailing issues in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix trailing issues in workflow file bentoml Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh executable and removed chmod command from the workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made modifications in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * deleted redundant files from tests folder Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Add kustomize installation file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made install_kustomize.sh file executable Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made a fix Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix issue with linting of YAML files (kubeflow#2825) * fix issue with linting of YAML files Signed-off-by: hansinikarunarathne <[email protected]> * delete a file to check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add the after checking the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add folders to yaml linting Signed-off-by: hansinikarunarathne <[email protected]> * check linting issues Signed-off-by: hansinikarunarathne <[email protected]> * check linting issues Signed-off-by: hansinikarunarathne <[email protected]> * check linting changes Signed-off-by: hansinikarunarathne <[email protected]> * check linting functionality by chnaging different files Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add github, hack and tests folders also for linting Signed-off-by: hansinikarunarathne <[email protected]> * Check functionality by deleting sh from hack and yaml file common Signed-off-by: hansinikarunarathne <[email protected]> * Added deleted files Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Expose Ray and Seldon to example kustomization.yaml file (kubeflow#2834) * Expose Ray and Seldon to example kustomization.yaml file Signed-off-by: hansinikarunarathne <[email protected]> * Add internal documentations for ray and seldon Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Increase the time out of notebook and katib test Signed-off-by: hansinikarunarathne <[email protected]> * increase the timout time Signed-off-by: hansinikarunarathne <[email protected]> * increase timeout of the create pipeline Run from Kubeflow Notebook to 2400s Signed-off-by: hansinikarunarathne <[email protected]> * Add code to calculate time taken to pull a docker image Signed-off-by: hansinikarunarathne <[email protected]> * fix syntax error in yaml file Signed-off-by: hansinikarunarathne <[email protected]> * increase pipeline time Signed-off-by: hansinikarunarathne <[email protected]> * remove one step in action Signed-off-by: hansinikarunarathne <[email protected]> * Added tests to tests/gh-actions to enable baseline and restricted PSS (kubeflow#2819) * Patched PSS labels to multi_tenancy Signed-off-by: biswajit-9776 <[email protected]> * Added script in gh-actions to patch PSS/static/baseline/pacthes Signed-off-by: biswajit-9776 <[email protected]> * Added PSS scripts for both baseline and restricted labels of static namespaces and renamed directories Signed-off-by: biswajit-9776 <[email protected]> * Added tests to enable PSS in gh-actions Signed-off-by: biswajit-9776 <[email protected]> * Added workflow test for PSS labels Signed-off-by: biswajit-9776 <[email protected]> * Fixed indentation Signed-off-by: biswajit-9776 <[email protected]> --------- Signed-off-by: biswajit-9776 <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * add kind cluster step into pss test yaml file Signed-off-by: hansinikarunarathne <[email protected]> * change time pot time Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: juliusvonkohout <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: biswajit-9776 <[email protected]> Co-authored-by: Julius von Kohout <[email protected]> Co-authored-by: biswajit-9776 <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]>
pschoen-itsc
pushed a commit
to pschoen-itsc/kf-manifests
that referenced
this pull request
Sep 3, 2024
* Training operator CICD improvements (kubeflow#2779) * Add the networkpolicies Signed-off-by: juliusvonkohout <[email protected]> * rework the training operator tests Signed-off-by: juliusvonkohout <[email protected]> * fix the comments Signed-off-by: juliusvonkohout <[email protected]> * fix filename Signed-off-by: juliusvonkohout <[email protected]> * try to fix the permissions Signed-off-by: juliusvonkohout <[email protected]> * try to fix the permissions Signed-off-by: juliusvonkohout <[email protected]> * change to the user namespace Signed-off-by: juliusvonkohout <[email protected]> * update the image to rc.1 Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> * fixes Signed-off-by: juliusvonkohout <[email protected]> --------- Signed-off-by: juliusvonkohout <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * create seperate file for install_KinD_create_KinD_cluster_install_kustomize.sh to avoid code repitition Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * make sh file executable Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * remove reduntant codes Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * combine kind, kuztomize and kind-cluster create sh files into one file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix issues with combined file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix configurations issues Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix linting issues in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix trailing issues in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix trailing issues in workflow file bentoml Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh executable and removed chmod command from the workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made modifications in workflow files Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * deleted redundant files from tests folder Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Add kustomize installation file Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made install_kustomize.sh file executable Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * made a fix Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * fix issue with linting of YAML files (kubeflow#2825) * fix issue with linting of YAML files Signed-off-by: hansinikarunarathne <[email protected]> * delete a file to check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add the after checking the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add folders to yaml linting Signed-off-by: hansinikarunarathne <[email protected]> * check linting issues Signed-off-by: hansinikarunarathne <[email protected]> * check linting issues Signed-off-by: hansinikarunarathne <[email protected]> * check linting changes Signed-off-by: hansinikarunarathne <[email protected]> * check linting functionality by chnaging different files Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <[email protected]> * Add github, hack and tests folders also for linting Signed-off-by: hansinikarunarathne <[email protected]> * Check functionality by deleting sh from hack and yaml file common Signed-off-by: hansinikarunarathne <[email protected]> * Added deleted files Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Expose Ray and Seldon to example kustomization.yaml file (kubeflow#2834) * Expose Ray and Seldon to example kustomization.yaml file Signed-off-by: hansinikarunarathne <[email protected]> * Add internal documentations for ray and seldon Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * Increase the time out of notebook and katib test Signed-off-by: hansinikarunarathne <[email protected]> * increase the timout time Signed-off-by: hansinikarunarathne <[email protected]> * increase timeout of the create pipeline Run from Kubeflow Notebook to 2400s Signed-off-by: hansinikarunarathne <[email protected]> * Add code to calculate time taken to pull a docker image Signed-off-by: hansinikarunarathne <[email protected]> * fix syntax error in yaml file Signed-off-by: hansinikarunarathne <[email protected]> * increase pipeline time Signed-off-by: hansinikarunarathne <[email protected]> * remove one step in action Signed-off-by: hansinikarunarathne <[email protected]> * Added tests to tests/gh-actions to enable baseline and restricted PSS (kubeflow#2819) * Patched PSS labels to multi_tenancy Signed-off-by: biswajit-9776 <[email protected]> * Added script in gh-actions to patch PSS/static/baseline/pacthes Signed-off-by: biswajit-9776 <[email protected]> * Added PSS scripts for both baseline and restricted labels of static namespaces and renamed directories Signed-off-by: biswajit-9776 <[email protected]> * Added tests to enable PSS in gh-actions Signed-off-by: biswajit-9776 <[email protected]> * Added workflow test for PSS labels Signed-off-by: biswajit-9776 <[email protected]> * Fixed indentation Signed-off-by: biswajit-9776 <[email protected]> --------- Signed-off-by: biswajit-9776 <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> * add kind cluster step into pss test yaml file Signed-off-by: hansinikarunarathne <[email protected]> * change time pot time Signed-off-by: hansinikarunarathne <[email protected]> --------- Signed-off-by: juliusvonkohout <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: hansinikarunarathne <[email protected]> Signed-off-by: biswajit-9776 <[email protected]> Co-authored-by: Julius von Kohout <[email protected]> Co-authored-by: biswajit-9776 <[email protected]> Signed-off-by: Patrick Schönthaler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tomize.sh to avoid code repitition
Pull Request Template for Kubeflow manifests Issues
✏️ A brief description of the changes
🐛 If this PR is related to an issue, please put the link to the issue here.
✅ Contributor checklist
DCOcheck)cla/googlecheck)