Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Make Request and limits configurable in KFP Driver and Launcher #11421

Open
rimolive opened this issue Nov 29, 2024 · 0 comments
Open

Comments

@rimolive
Copy link
Member

rimolive commented Nov 29, 2024

The memory and cpu limit/request ratio for driver and launcher are hard-coded values.

In a multi-tenant cluster with a configured resource limit/request ratio this will block the pods from being started. Pod is not getting created from the resulted argoworkflow of the KFP DSL, since the root-driver and kfp-launcher containers are not even being admitted.

Error node pipeline-step-f9888.root-driver: task 'document-ingestion-f9888.root-driver' errored:pods"pipeline-step-f9888-172800538" is forbidden: memorymax limit to request ratio per Container is 3, butprovidedratio is 8.000000

Environment

  • How did you deploy Kubeflow Pipelines (KFP)?
    Manifests, multi-user
  • KFP version:
    2.3.0
  • KFP SDK version:
    2.10.1

Steps to reproduce

  • Deploy KFP
  • Specify a LimitRange in kubeflow namespace. Note that maxLimitRequestRatio but have a value higher than 3
  • Create a pipeline run

Expected result

Pipeline should run without breaking any restrictions from the LimitRange

Materials and Reference

N/A


Impacted by this bug? Give it a 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant