Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk] Invalid pipeline_name error handling #11423

Open
RodionSkrupskiy opened this issue Nov 30, 2024 · 2 comments
Open

[sdk] Invalid pipeline_name error handling #11423

RodionSkrupskiy opened this issue Nov 30, 2024 · 2 comments
Assignees

Comments

@RodionSkrupskiy
Copy link

Environment

  • KFP version:
  • KFP SDK version:
  • All dependencies version:

kfp 2.7.0
kfp-pipeline-spec 0.3.0
kfp-server-api 2.0.5

Steps to reproduce

When running kfp.compiler.Compiler().compile() function and passing the parameter pipeline_name with invalid name, the 400 Client Error: Bad Request for url: ... comes in. And the bug is complicated to debug

Expected result

The correct behavior could be a ValueError raised by validate_pipeline_name function.

Materials and Reference

For example:

kfp.compiler.Compiler().compile(
    pipeline_func=pipeline_func, 
    package_path="package_path.yaml", 
    pipeline_name="ml-pipeline_test"
)

A valid pipeline name should match ^[a-z0-9][a-z0-9-]{0,127}$ as specified in validate_pipeline_name function in sdk/python/kfp/compiler/pipeline_spec_builder_test.py file.


Impacted by this bug? Give it a 👍.

@Yael-F
Copy link
Contributor

Yael-F commented Dec 25, 2024

@HumairAK Can you pls assign this bug on me?

@hbelmiro
Copy link
Contributor

/assign @Yael-F

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants