Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Training Operator release process #2155

Open
andreyvelich opened this issue Jun 25, 2024 · 10 comments · May be fixed by #2359 or #2362
Open

Improve Training Operator release process #2155

andreyvelich opened this issue Jun 25, 2024 · 10 comments · May be fixed by #2359 or #2362
Assignees
@Deathfireofdoom @Veer0x1
Labels
good first issue help wanted

Comments

@andreyvelich
Copy link
Member

Related: kubeflow/katib#2049

We need to improve our release process for Training Operator:

  • Branch names should follow this pattern: release-X.Y. Similar to Katib or Kubernetes.
  • Automate release with GitHub Actions.

/good-first-issue
/help
@google-oss-prow Google OSS Prow
Copy link

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Related: kubeflow/katib#2049

We need to improve our release process for Training Operator:

  • Branch names should follow this pattern: release-X.Y. Similar to Katib or Kubernetes.
  • Automate release with GitHub Actions.

/good-first-issue
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@7h3-3mp7y-m4n
Copy link

I want to take this.
/assign

@tenzen-y
Copy link
Member

Additionally, I would like to use the semantic versioning image tags every for the release here:

training-operator/manifests/overlays/standalone/kustomization.yaml

Line 9 in f8687ca

newTag: "v1-9e52eb7"

@tenzen-y tenzen-y mentioned this issue Jul 25, 2024
Merged
@mszadkow mszadkow mentioned this issue Jul 29, 2024
Closed
@7h3-3mp7y-m4n
Copy link

okay I'll look at it and raise a PR ASAP

@7h3-3mp7y-m4n 7h3-3mp7y-m4n removed their assignment Oct 15, 2024
@Deathfireofdoom
Copy link

No one is working on this one right? I can take a look
/assign

@tenzen-y
Copy link
Member

tenzen-y commented Nov 1, 2024

No one is working on this one right? I can take a look /assign

Yes, feel free to take this.

@andreyvelich
Copy link
Member Author

Thank you for your time @Deathfireofdoom!
I would also suggest to also check how we refactor and automate the Spark Operator release process with @ChenYi015 : kubeflow/spark-operator#2089

I think, we can re-use some of the steps.

@andreyvelich andreyvelich mentioned this issue Dec 5, 2024
Open
@Veer0x1
Copy link
Contributor

Veer0x1 commented Dec 14, 2024

Hey @Deathfireofdoom if you're not working on this issue, then I would like to work on it.

@Deathfireofdoom
Copy link

@Veer0x1 Sorry for the delay, started tackling it but got hectic at work, chapter 11 stuff hahah, so will probably not have time to look into this more until after holiday anyway! So feel free to take it! :)

@Veer0x1
Copy link
Contributor

Veer0x1 commented Dec 21, 2024

/assign

@Veer0x1 Veer0x1 linked a pull request Dec 22, 2024 that will close this issue
Open
1 task
@LogicalGuy77 LogicalGuy77 linked a pull request Dec 23, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Deathfireofdoom Deathfireofdoom

@Veer0x1 Veer0x1

Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
5 participants
@andreyvelich @Deathfireofdoom @tenzen-y @Veer0x1 @7h3-3mp7y-m4n