/help

@roycaihw:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

Hi,

I am beginner to Kuberenetes repo. Do you think this is a good issue to pick?

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

/remove-lifecycle stale

+1 for this - Would be great to have this

Adding my +1 to prevent this from becoming stale.

Came across this researching providing HA on an operator based solution and wanted to have this Lease-base lock implemented. Got a fork setup through my company and plan to contribute this back to the project. Just need to know the process for contributing this back. Thanks

@rvlane you can send a PR similar to https://github.com/kubernetes-client/python/pull/1747/commits. Hope that helps. I can review it.

cc: @roycaihw

@Invictus17 Thanks. Starting work on this now.

@Invictus17 Implementation question:
Currently the LeaderElectionRecord saves the string representation of the times and lease_duration. I woiuld prefer to change this to save the raw datetime object and let ConfigMapLock and the new LeaseLock decode as needed since currently ConfigMapLock saves to the annotation in string format and the isoformat is required by the V1Lease object. Reluctant to do this in case anyone is using the LeaderElectioniRecord itself. So question is: Can I change LeaderElectionRecord to store raw objects instead of string representations? Otherwise, if need to keep this record structure in tact, will convert from string to object, then to isoformat for the V1Lease. Thanks.

cc: @roycaihw

@Invictus17 Pull request created: #2314