Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions and Helm Charts for containers in use are confusing and provide different behaviours #853

Closed
saintdle opened this issue Apr 27, 2021 · 5 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@saintdle
Copy link

/kind bug

What happened?

When following the linked instructions for snapshot feature with the EBS CSI driver, creating a snapshot just hangs completely. Unable to read any logs from the snapshot controller as it's exited and no previous logs are available.

If I roll the deployment back, and deploy the CSI Driver using Helm with the feature gates. And then annotate my controller pods with ARN, and install the CRDs from here ,as there are none deployed by Helm. Then things work as expected.

What you expected to happen?

When following the standard install it should work with the external pre-reqs links provided.

When using helm, the snapshot related CRDs should be installed

How to reproduce it (as minimally and precisely as possible)?

Using the out of the box instructions - deploy driver with alpha features

kubectl apply -k "github.com/kubernetes-sigs/aws-ebs-csi-driver/deploy/kubernetes/overlays/alpha/?ref=master"

Then follow this provided snapshot instructions link. When you get to Step 3 of the pre-reqs in this page, you are sent to this document. Once followed those steps to create CRD, and snapshot controller. And then create the VolumeSnapshotClass from the provided example back on the AWS EBS CSI snapshot page.

When running the example pv and snapshot creation. The PV creates ok, but the snapshot just says;

Events:
Type Reason Age From Message


Normal CreatingSnapshot 5m36s snapshot-controller Waiting for a snapshot default/new-snapshot-demo to be created by the CSI driver.

Anything else we need to know?:

Environment

  • Kubernetes version (use kubectl version): v1.18.9-eks-d1db3c
  • Driver version: latest
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 27, 2021
@wongma7
Copy link
Contributor

wongma7 commented Apr 27, 2021

Sorry about this, yes we're aware of this issue...by default, the helm chart doesnt install necessary snapshot, including CRD, and it's not documented that you need to do it yourself. I think this is a consequence of the chart not being updated for a while (since snapshot feature was alpha but has since graduated to ga... not making excuse, just explaining.)

related:
#797

@saintdle
Copy link
Author

Sorry about this, yes we're aware of this issue...by default, the helm chart doesnt install necessary snapshot, including CRD, and it's not documented that you need to do it yourself. I think this is a consequence of the chart not being updated for a while (since snapshot feature was alpha but has since graduated to ga... not making excuse, just explaining.)

related:
#797

No worries, was just a good few hoops to jump through, and we kept hitting different outcomes for what we needed at the time.

@krmichel
Copy link
Contributor

krmichel commented Jul 5, 2021

This issue is related to issue #635

@krmichel
Copy link
Contributor

Version 2.0.0 of the chart no longer installs the snapshot controller or its CRDs. The documentation linked here should be updated to reflect that.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 12, 2021
@wongma7 wongma7 closed this as completed Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants