Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions in doc to update release versions in security-scan workflow #1499

Open
Prajyot-Parab opened this issue Nov 16, 2023 · 7 comments
Assignees
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation.
Milestone

Comments

@Prajyot-Parab
Copy link
Contributor

/kind documentation
/area provider/ibmcloud

Describe the solution you'd like
Add instructions in doc to update release versions in security-scan workflow

  • Add newly release version to workflow
  • Remove n-2th unsupported version on new release from workflow
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Nov 16, 2023
@Prajyot-Parab
Copy link
Contributor Author

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@Prajyot-Parab:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Nov 16, 2023
@mkumatag mkumatag added this to the Next milestone Nov 17, 2023
@Niharika0306
Copy link
Contributor

/assign

@Prajyot-Parab
Copy link
Contributor Author

@Niharika0306 We recently introduced this workflow - https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/.github/workflows/weekly-security-scan.yaml#L16

Add clear instructions here https://cluster-api-ibmcloud.sigs.k8s.io/developer/dependencies
ref - https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/docs/book/src/developer/dependencies.md

Instruction (rough:) version, please frame properly)

  • update the release versions in workflow once a new release is out
  • remove the n-2 release from the workflow list

@pravarag
Copy link

pravarag commented Mar 5, 2024

Hi @Prajyot-Parab , can I pick this good-first-issue to work on if it's still available as I'm starting fresh?

@mkumatag
Copy link
Member

mkumatag commented Mar 8, 2024

Hi @Prajyot-Parab , can I pick this good-first-issue to work on if it's still available as I'm starting fresh?

go ahead and assign it to yourself.

@pravarag
Copy link

pravarag commented Mar 8, 2024

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

No branches or pull requests

5 participants