Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MeshFrontendHostname cannot be indicated separately. #2711

Closed
LiorLieberman opened this issue Jan 11, 2024 · 8 comments
Closed
Assignees
Labels
area/conformance kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@LiorLieberman
Copy link
Member

/area conformance

What happened:
Looking at mesh-frontend-hostname.go conformance test, it looks like every implementation that claims to support Mesh and also implements HTTPRouteResponseHeaderModification extended feature have to conform with this test.

However it does not look like it is the case. For example Istio, skips this test

Is this feature part of Core Mesh features or we should introduce new supportedFeature for it. Now there is not way to indicate if an implementation supports Mesh, HTTPRouteResponseHeaderModification but DOESNT support MeshFrontendHostname.

/assign @howardjohn
/cc @robscott

@LiorLieberman LiorLieberman added the kind/bug Categorizes issue or PR as related to a bug. label Jan 11, 2024
@robscott
Copy link
Member

/cc @kflynn @keithmattix

@howardjohn
Copy link
Contributor

I am a bit confused that we cannot report "not support MeshFrontendHostname"?

Is this not reported via

    skippedTests:
    - MeshFrontendHostname

@LiorLieberman
Copy link
Member Author

Since there is no supportFeature for it, you cant really indicate it in GatewayClass Status (ref)

@robscott
Copy link
Member

It seems like if an individual test is regularly skipped instead of just omitting a "SupportedFeature" we should add a feature for the functionality covered by that test so it can clearly be indicated by GatewayClass status. In this case, the conformance test is mesh-specific so it may not really make a meaningful difference since Meshes don't have a way to publish Supported Features via status yet. Even if it won't make a significant difference, I'd recommend just adding a supported feature for the sake of consistency with other tests.

@LiorLieberman
Copy link
Member Author

Meshes don't have a way to publish Supported Features via status yet.

To clarify, we do publish "Mesh" in supportedFeatues in Gateway class if an implementation claims it supports AllFeatures (it comes from SupportMesh supportedFeature)

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 16, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 16, 2024
@robscott
Copy link
Member

This was actually fixed by #3035

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/conformance kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants