-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for MeshFrontendHostname cannot be indicated separately. #2711
Comments
/cc @kflynn @keithmattix |
I am a bit confused that we cannot report "not support MeshFrontendHostname"? Is this not reported via
|
Since there is no supportFeature for it, you cant really indicate it in GatewayClass Status (ref) |
It seems like if an individual test is regularly skipped instead of just omitting a "SupportedFeature" we should add a feature for the functionality covered by that test so it can clearly be indicated by GatewayClass status. In this case, the conformance test is mesh-specific so it may not really make a meaningful difference since Meshes don't have a way to publish Supported Features via status yet. Even if it won't make a significant difference, I'd recommend just adding a supported feature for the sake of consistency with other tests. |
To clarify, we do publish "Mesh" in supportedFeatues in Gateway class if an implementation claims it supports AllFeatures (it comes from SupportMesh supportedFeature) |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
This was actually fixed by #3035 |
/area conformance
What happened:
Looking at mesh-frontend-hostname.go conformance test, it looks like every implementation that claims to support Mesh and also implements HTTPRouteResponseHeaderModification extended feature have to conform with this test.
However it does not look like it is the case. For example Istio, skips this test
Is this feature part of Core Mesh features or we should introduce new supportedFeature for it. Now there is not way to indicate if an implementation supports
Mesh
,HTTPRouteResponseHeaderModification
but DOESNT supportMeshFrontendHostname
./assign @howardjohn
/cc @robscott
The text was updated successfully, but these errors were encountered: