-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for IngressClass
objects
#117
Comments
/help |
@levikobi: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/good-first-issue |
@mlavacca: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
I have created a PR for the same. Kindly review it. |
I just now noticed that @akagami-harsh asked to work on this issue first. |
@levikobi yes i am interested. i was busy with other things, but now i am free |
Since there's already an open PR for this issue, should I create a new one? |
Hi @akagami-harsh, no. Please check out other issues like #81 if you are still up for contributing. We would love to have you. @Varun1300211 While we appreciate you quickly made a PR and sent for review, next time, please kindly try to confirm with the current assignee if he is working on it before proceeding with a PR |
Apologies @akagami-harsh, I am still very new to the open source. Never seen you were already assigned to it before. Hope you understand. Sure @LiorLieberman will keep it in mind from the next time onwards. |
No worries at all, @Varun1300211! It happens, and I appreciate you being open to the feedback. Thanks for letting me know, @LiorLieberman . I'll take a look at issue #81. |
hi @akagami-harsh, are you still working on it, I would like to give it a try. 😊 /assign |
@ipsum-0320, please notice @Varun1300211 is already assigned to this issue. @Varun1300211, are you still working on it? |
okok, I will wait until @Varun1300211 replies before taking the next step 😊 |
/assign |
@levikobi @LiorLieberman |
At the time I opened this issue this was correct @VasuDevrani, I think this still holds true though. |
Hi @VasuDevrani, any news on this issue? If you need some help, please let us know :) |
hey @mlavacca is this issue still open to contributions ?? |
What would you like to be added:
Add support for reading and taking into account
IngressClass
objects.Why this is needed:
If users do not specify
ingressClassName
, we need to understand the defaultIngressClass
that should be used for the conversion.The text was updated successfully, but these errors were encountered: