Added IngressClass objects support #117 #132

Varun1300211 · 2024-02-13T18:31:48Z

What type of PR is this?
This pull request implements IngressClass support.

Add one of the following kinds:
/kind feature

What this PR does / why we need it:
It retrieves the default IngressClass based on its API group (networking.k8s.io) and a dedicated annotation (ingressclass.kubernetes.io/is-default-class).
If no explicit IngressClass is specified in the Ingress object or via annotation, the default class is used for resource processing.

Which issue(s) this PR fixes:

Fixes #117

Does this PR introduce a user-facing change?:

Please do let me know if it was done in the correct way.

linux-foundation-easycla · 2024-02-13T18:31:52Z

The committers listed above are authorized under a signed CLA.

✅ login: Varun1300211 / name: Varun Kumar Gupta (6293f14, 5b80862)

k8s-ci-robot · 2024-02-13T18:31:54Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Varun1300211
Once this PR has been reviewed and has the lgtm label, please assign bowei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2024-02-13T18:31:57Z

Welcome @Varun1300211!

It looks like this is your first PR to kubernetes-sigs/ingress2gateway 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/ingress2gateway has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-02-13T18:31:58Z

Hi @Varun1300211. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Varun1300211 · 2024-02-13T18:41:17Z

/easycla

LiorLieberman · 2024-02-13T18:42:00Z

/ok-to-test

LiorLieberman · 2024-02-13T18:44:03Z

Thanks @Varun1300211 !

I will probably look at it tomorrow. In the meantime, can you:

add a release_note block in the PR description (it should be added by default every PR but looks like you deleted it)
Retitle the PR to reflect exactly the change your are adding
Why did you update go mod (probably you run go mod tidy)? I dont think thats needed so if you can revert it it will be awesome.

Thanks!
/hold

Varun1300211 · 2024-02-13T20:02:20Z

Done all the changes requested by you @LiorLieberman, please let me know if anything else is required.

levikobi

Thanks @Varun1300211 and welcome!
I left a few comments regarding some things that need to be taken into account.
If you have any questions or need any help feel free to let us know

pkg/i2gw/providers/common/utils.go

k8s-ci-robot · 2024-02-14T21:10:07Z

@Varun1300211: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-ingress2gateway-verify	`5b80862`	link	true	`/test pull-ingress2gateway-verify`
pull-ingress2gateway-test	`5b80862`	link	true	`/test pull-ingress2gateway-test`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Varun1300211 · 2024-02-14T21:13:29Z

Hi @levikobi, I made the changes suggested by you. Please take a look.

levikobi

Thanks again @Varun1300211!
I think it may help you to try playing around with the tool for a bit and see the different options it provides. Afterwards maybe try to compile your version and see what changes/breaks.

This new addition needs to take into account different options the user may pass.

levikobi · 2024-02-18T18:04:17Z

pkg/i2gw/providers/common/utils.go

+	switch extension {
+	case "yaml":
+		err = yaml.Unmarshal(data, ingressClasses)
+	case "json":
+		err = json.Unmarshal(data, ingressClasses)
+	default:
+		return nil, fmt.Errorf("unsupported file type: %s", extension)
+	}


Maybe I missed something but it seems like you're always sending an empty slice of data

levikobi · 2024-02-18T18:07:58Z

pkg/i2gw/providers/common/utils.go

+func init() {
+
+	config, err := rest.InClusterConfig()
+	if err != nil {
+		log.Fatal(errors.New("unable to create config"))
+	}
+
+	k8sClientset, err = kubernetes.NewForConfig(config)
+	if err != nil {
+		log.Fatal(err)
+	}
+}


This init function will always try to create a k8s client, even if the user doesn't have a cluster and want to convert some local file.

You'll need to pass the user's choice of where he wants to read resources from (cluster or file) and the k8s client, which was initialized in the i2gw package.

LiorLieberman · 2024-03-02T16:54:42Z

@Varun1300211 Just checking in, please let us know if you need any help with moving this forward

LiorLieberman · 2024-04-03T09:58:39Z

@Varun1300211 a friendly ping, are you still planning to work on this?

k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 13, 2024

k8s-ci-robot requested review from levikobi and Xunzhuo February 13, 2024 18:31

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 13, 2024

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 13, 2024

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 13, 2024

Varun1300211 had a problem deploying to release February 13, 2024 18:41 — with GitHub Actions Failure

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 13, 2024

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2024

Varun1300211 changed the title ~~Related to issue #117~~ Added IngressClass objects support #117 Feb 13, 2024

levikobi reviewed Feb 14, 2024

View reviewed changes

pkg/i2gw/providers/common/utils.go Show resolved Hide resolved

pkg/i2gw/providers/common/utils.go Outdated Show resolved Hide resolved

pkg/i2gw/providers/common/utils.go Outdated Show resolved Hide resolved

Test commit

6293f14

Varun1300211 force-pushed the main branch from 28fab92 to 6293f14 Compare February 14, 2024 17:03

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 14, 2024

Added local file functionality and other changes to utils.go

5b80862

levikobi suggested changes Feb 18, 2024

View reviewed changes

LiorLieberman closed this May 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added IngressClass objects support #117 #132

Added IngressClass objects support #117 #132

Varun1300211 commented Feb 13, 2024 •

edited

Loading

linux-foundation-easycla bot commented Feb 13, 2024 •

edited

Loading

k8s-ci-robot commented Feb 13, 2024

k8s-ci-robot commented Feb 13, 2024

k8s-ci-robot commented Feb 13, 2024

Varun1300211 commented Feb 13, 2024

LiorLieberman commented Feb 13, 2024

LiorLieberman commented Feb 13, 2024

Varun1300211 commented Feb 13, 2024

levikobi left a comment

k8s-ci-robot commented Feb 14, 2024

Varun1300211 commented Feb 14, 2024

levikobi left a comment

levikobi Feb 18, 2024

levikobi Feb 18, 2024

LiorLieberman commented Mar 2, 2024

LiorLieberman commented Apr 3, 2024

Added IngressClass objects support #117 #132

Added IngressClass objects support #117 #132

Conversation

Varun1300211 commented Feb 13, 2024 • edited Loading

linux-foundation-easycla bot commented Feb 13, 2024 • edited Loading

k8s-ci-robot commented Feb 13, 2024

k8s-ci-robot commented Feb 13, 2024

k8s-ci-robot commented Feb 13, 2024

Varun1300211 commented Feb 13, 2024

LiorLieberman commented Feb 13, 2024

LiorLieberman commented Feb 13, 2024

Varun1300211 commented Feb 13, 2024

levikobi left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Feb 14, 2024

Varun1300211 commented Feb 14, 2024

levikobi left a comment

Choose a reason for hiding this comment

levikobi Feb 18, 2024

Choose a reason for hiding this comment

levikobi Feb 18, 2024

Choose a reason for hiding this comment

LiorLieberman commented Mar 2, 2024

LiorLieberman commented Apr 3, 2024

Varun1300211 commented Feb 13, 2024 •

edited

Loading

linux-foundation-easycla bot commented Feb 13, 2024 •

edited

Loading